jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-21 09:05:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Document transaction teardown in deck share rollback paths

Browse source
This commit is contained in:
Lukas Brübach 2026-09-18 22:57:37 +02:00 • committed by GitHub
parent b7e4afa399
commit 02b4e8d13d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
servatrice/src/servatrice_database_interface.cpp
View file

@ -1105,6 +1105,8 @@ bool Servatrice_DatabaseInterface::createDeckShare(const QString &token,
query->bindValue(":created_by", userId < 1 ? QVariant() : userId); query->bindValue(":created_by", userId < 1 ? QVariant() : userId);
query->bindValue(":days", expiryDays); query->bindValue(":days", expiryDays);
if (!execSqlQuery(query)) { if (!execSqlQuery(query)) {
// A failed execSqlQuery has already closed and reopened the connection,
// which implicitly discards the transaction; rollback below is a no-op.
sqlDatabase.rollback(); sqlDatabase.rollback();
return false; return false;
} }
@ -1116,6 +1118,8 @@ bool Servatrice_DatabaseInterface::createDeckShare(const QString &token,
QSqlQuery *expiryQuery = prepareQuery("select UNIX_TIMESTAMP(expires_at) from {prefix}_deck_share where id = :id"); QSqlQuery *expiryQuery = prepareQuery("select UNIX_TIMESTAMP(expires_at) from {prefix}_deck_share where id = :id");
expiryQuery->bindValue(":id", shareId); expiryQuery->bindValue(":id", shareId);
if (!execSqlQuery(expiryQuery) || !expiryQuery->next()) { if (!execSqlQuery(expiryQuery) || !expiryQuery->next()) {
// See the note above: after a failed execSqlQuery the transaction is
// already gone because the connection was torn down.
sqlDatabase.rollback(); sqlDatabase.rollback();
return false; return false;
} }
@ -1135,6 +1139,8 @@ bool Servatrice_DatabaseInterface::createDeckShare(const QString &token,
itemQuery->bindValue(":content", item.content); itemQuery->bindValue(":content", item.content);
itemQuery->bindValue(":position", i); itemQuery->bindValue(":position", i);
if (!execSqlQuery(itemQuery)) { if (!execSqlQuery(itemQuery)) {
// See the note above: the transaction is already gone after the
// reconnect performed by a failed execSqlQuery.
sqlDatabase.rollback(); sqlDatabase.rollback();
return false; return false;
} }