Remove test header guard

Took 4 seconds

libcockatrice_settings/CMakeLists.txt

@@ -67,7 +67,3 @@ target_include_directories(
 )
 
 target_link_libraries(libcockatrice_settings PUBLIC libcockatrice_card libcockatrice_utility ${QT_CORE_MODULE})
-
-if(TEST)
-  target_compile_definitions(libcockatrice_settings PRIVATE SETTINGS_UNIT_TEST)
-endif()

libcockatrice_settings/libcockatrice/settings/cache_storage_settings.h

@@ -47,11 +47,7 @@ signals:
     void cardPictureLoaderCacheMethodChanged(int cardPictureLoaderCacheMethod);
     void localCardImageStorageNamingSchemeChanged(int localCardImageStorageNamingScheme);
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit CacheStorageSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/chat_settings.h

@@ -42,11 +42,7 @@ public:
 signals:
     void chatMentionCompleterChanged();
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit ChatSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/game_settings.h

@@ -45,11 +45,7 @@ public:
     void setLocalGameMaxPlayers(int value);
     void setLocalGameStartingLifeTotal(int value);
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit GameSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/personal_settings.h

@@ -55,11 +55,7 @@ signals:
     void homeTabDisplayCardNameChanged();
     void downloadSpoilerStatusChanged();
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit PersonalSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/sound_settings.h

@@ -24,11 +24,7 @@ signals:
     void soundThemeChanged();
     void masterVolumeChanged(int value);
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit SoundSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/tabs_settings.h

@@ -27,11 +27,7 @@ public:
     void setTabAdminOpen(bool value);
     void setTabLogOpen(bool value);
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit TabsSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/updates_settings.h

@@ -33,11 +33,7 @@ public:
     void setNotifyAboutNewVersion(bool _notifyaboutnewversion);
     void setUpdateReleaseChannelIndex(int value);
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit UpdatesSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private:

libcockatrice_settings/libcockatrice/settings/visual_deck_storage_settings.h

@@ -81,11 +81,7 @@ signals:
     void edhRecCardSizeChanged();
     void archidektPreviewSizeChanged();
 
-#ifdef SETTINGS_UNIT_TEST
 public:
-#else
-private:
-#endif
     explicit VisualDeckStorageSettings(const QString &settingPath, QObject *parent = nullptr);
 
 private: