From 0f002ae0673a1778b68f98413513176ab4f73bf1 Mon Sep 17 00:00:00 2001
From: RickyRister <ricky.rister.wang@gmail.com>
Date: Mon, 16 Dec 2024 19:20:13 -0800
Subject: [PATCH] refactor

---
 cockatrice/src/game/zones/table_zone.cpp | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/cockatrice/src/game/zones/table_zone.cpp b/cockatrice/src/game/zones/table_zone.cpp
index af4b82e18..19f7eebcb 100644
--- a/cockatrice/src/game/zones/table_zone.cpp
+++ b/cockatrice/src/game/zones/table_zone.cpp
@@ -214,15 +214,12 @@ void TableZone::reorganizeCards()
 void TableZone::toggleTapped()
 {
     QList<QGraphicsItem *> selectedItems = scene()->selectedItems();
-    bool tapAll = false;
-    for (int i = 0; i < selectedItems.size(); i++)
-        if (!qgraphicsitem_cast<CardItem *>(selectedItems[i])->getTapped()) {
-            tapAll = true;
-            break;
-        }
+    bool tapAll = std::any_of(selectedItems.begin(), selectedItems.end(), [](const QGraphicsItem *item) {
+        return !qgraphicsitem_cast<const CardItem *>(item)->getTapped();
+    });
     QList<const ::google::protobuf::Message *> cmdList;
-    for (int i = 0; i < selectedItems.size(); i++) {
-        CardItem *temp = qgraphicsitem_cast<CardItem *>(selectedItems[i]);
+    for (const auto &selectedItem : selectedItems) {
+        CardItem *temp = qgraphicsitem_cast<CardItem *>(selectedItem);
         if (temp->getTapped() != tapAll) {
             Command_SetCardAttr *cmd = new Command_SetCardAttr;
             cmd->set_zone(name.toStdString());