jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-29 12:20:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050)

Browse source 
* [Settings] Split cache_settings into multiple files

Took 9 minutes

Took 4 minutes

* [Settings] Fwd declare settings classes in cache_settings

Took 15 minutes

* Fix oracle includes.

Took 8 minutes

* Address comments, fix windows CI

Took 8 minutes

* fix copy constructor visibility

Took 3 minutes

* lint

Took 2 minutes

* Fix native format tests.

Took 5 minutes

* Remove test header guard

Took 4 seconds

* Remove tests invalid in CI environ

Took 24 seconds

* Adjust to rebase.

Took 11 minutes

* Change settings file name.

Took 8 minutes

---------

Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de>
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2026-07-27 11:25:39 +02:00 • committed by GitHub
parent cf0b453e75
commit 12f0f59453
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
166 changed files with 5589 additions and 3066 deletions
Download patch file Download diff file Expand all files Collapse all files

16
libcockatrice_interfaces/libcockatrice/interfaces/interface_sound_settings_provider.h Normal file
View file

@ -0,0 +1,16 @@
#ifndef COCKATRICE_INTERFACE_SOUND_SETTINGS_PROVIDER_H
#define COCKATRICE_INTERFACE_SOUND_SETTINGS_PROVIDER_H
#include <QString>
class ISoundSettingsProvider
{
public:
virtual ~ISoundSettingsProvider() = default;
[[nodiscard]] virtual bool getSoundEnabled() const = 0;
[[nodiscard]] virtual QString getSoundThemeName() const = 0;
[[nodiscard]] virtual int getMasterVolume() const = 0;
};
#endif // COCKATRICE_INTERFACE_SOUND_SETTINGS_PROVIDER_H