jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-29 12:20:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050)

Browse source 
* [Settings] Split cache_settings into multiple files

Took 9 minutes

Took 4 minutes

* [Settings] Fwd declare settings classes in cache_settings

Took 15 minutes

* Fix oracle includes.

Took 8 minutes

* Address comments, fix windows CI

Took 8 minutes

* fix copy constructor visibility

Took 3 minutes

* lint

Took 2 minutes

* Fix native format tests.

Took 5 minutes

* Remove test header guard

Took 4 seconds

* Remove tests invalid in CI environ

Took 24 seconds

* Adjust to rebase.

Took 11 minutes

* Change settings file name.

Took 8 minutes

---------

Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de>
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2026-07-27 11:25:39 +02:00 • committed by GitHub
parent cf0b453e75
commit 12f0f59453
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
166 changed files with 5589 additions and 3066 deletions
Download patch file Download diff file Expand all files Collapse all files

34
libcockatrice_settings/libcockatrice/settings/sound_settings.h Normal file
View file

@ -0,0 +1,34 @@
#ifndef SOUND_SETTINGS_H
#define SOUND_SETTINGS_H
#include "settings_manager.h"
#include <libcockatrice/interfaces/interface_sound_settings_provider.h>
class SoundSettings : public SettingsManager, public ISoundSettingsProvider
{
Q_OBJECT
friend class SettingsCache;
public:
[[nodiscard]] bool getSoundEnabled() const override;
[[nodiscard]] QString getSoundThemeName() const override;
[[nodiscard]] int getMasterVolume() const override;
void setSoundEnabled(bool _soundEnabled);
void setSoundThemeName(const QString &_soundThemeName);
void setMasterVolume(int _masterVolume);
signals:
void soundEnabledChanged();
void soundThemeChanged();
void masterVolumeChanged(int value);
public:
explicit SoundSettings(const QString &settingPath, QObject *parent = nullptr);
private:
SoundSettings(const SoundSettings & /*other*/);
};
#endif // SOUND_SETTINGS_H