[Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050)

* [Settings] Split cache_settings into multiple files Took 9 minutes Took 4 minutes * [Settings] Fwd declare settings classes in cache_settings Took 15 minutes * Fix oracle includes. Took 8 minutes * Address comments, fix windows CI Took 8 minutes * fix copy constructor visibility Took 3 minutes * lint Took 2 minutes * Fix native format tests. Took 5 minutes * Remove test header guard Took 4 seconds * Remove tests invalid in CI environ Took 24 seconds * Adjust to rebase. Took 11 minutes * Change settings file name. Took 8 minutes --------- Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de> Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-07-29 04:10:23 -07:00 · 2026-07-27 11:25:39 +02:00 · 2026-07-27 11:25:39 +02:00 · 12f0f59453
commit 12f0f59453
parent cf0b453e75
166 changed files with 5589 additions and 3066 deletions
--- a/tests/settings/settings_defaults_test.cpp
+++ b/tests/settings/settings_defaults_test.cpp
@ -0,0 +1,355 @@
+#include "gtest/gtest.h"
+#include <QSettings>
+#include <QTemporaryDir>
+#include <libcockatrice/settings/cache_storage_settings.h>
+#include <libcockatrice/settings/chat_settings.h>
+#include <libcockatrice/settings/game_settings.h>
+#include <libcockatrice/settings/personal_settings.h>
+#include <libcockatrice/settings/sound_settings.h>
+#include <libcockatrice/settings/tabs_settings.h>
+#include <libcockatrice/settings/updates_settings.h>
+#include <libcockatrice/settings/visual_deck_storage_settings.h>
+
+namespace
+{
+
+class SettingsDefaultsTest : public ::testing::Test
+{
+protected:
+    QTemporaryDir tempDir;
+    QString settingsPath;
+
+    void SetUp() override
+    {
+        settingsPath = tempDir.path() + "/";
+    }
+};
+
+// --- CacheStorageSettings ---
+
+TEST_F(SettingsDefaultsTest, CacheStorage_PixmapCacheSize_Default)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getPixmapCacheSize(), PIXMAPCACHE_SIZE_DEFAULT);
+}
+
+TEST_F(SettingsDefaultsTest, CacheStorage_PixmapCacheSize_SetAndGet)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    s.setPixmapCacheSize(1024);
+    ASSERT_EQ(s.getPixmapCacheSize(), 1024);
+}
+
+TEST_F(SettingsDefaultsTest, CacheStorage_NetworkCacheSizeInMB_Default)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getNetworkCacheSizeInMB(), NETWORK_CACHE_SIZE_DEFAULT);
+}
+
+TEST_F(SettingsDefaultsTest, CacheStorage_RedirectCacheTtl_Default)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getRedirectCacheTtl(), NETWORK_REDIRECT_CACHE_TTL_DEFAULT);
+}
+
+TEST_F(SettingsDefaultsTest, CacheStorage_CardPictureLoaderCacheMethod_Default)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getCardPictureLoaderCacheMethod(), 0);
+}
+
+TEST_F(SettingsDefaultsTest, CacheStorage_LocalCardImageStorageNamingScheme_Default)
+{
+    CacheStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getLocalCardImageStorageNamingScheme(), LOCAL_CARD_IMAGE_NAMING_SCHEME_DEFAULT);
+}
+
+// --- GameSettings ---
+
+TEST_F(SettingsDefaultsTest, Game_MaxPlayers_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getMaxPlayers(), 2);
+}
+
+TEST_F(SettingsDefaultsTest, Game_MaxPlayers_SetAndGet)
+{
+    GameSettings s(settingsPath, nullptr);
+    s.setMaxPlayers(4);
+    ASSERT_EQ(s.getMaxPlayers(), 4);
+}
+
+TEST_F(SettingsDefaultsTest, Game_DefaultStartingLifeTotal_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getDefaultStartingLifeTotal(), 20);
+}
+
+TEST_F(SettingsDefaultsTest, Game_RememberGameSettings_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getRememberGameSettings(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Game_LocalGameMaxPlayers_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getLocalGameMaxPlayers(), 1);
+}
+
+TEST_F(SettingsDefaultsTest, Game_LocalGameStartingLifeTotal_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getLocalGameStartingLifeTotal(), 20);
+}
+
+TEST_F(SettingsDefaultsTest, Game_LocalGameRememberSettings_Default)
+{
+    GameSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getLocalGameRememberSettings(), false);
+}
+
+// --- UpdatesSettings ---
+
+TEST_F(SettingsDefaultsTest, Updates_CheckUpdatesOnStartup_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getCheckUpdatesOnStartup(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_StartupCardUpdateCheckPromptForUpdate_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getStartupCardUpdateCheckPromptForUpdate(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_StartupCardUpdateCheckAlwaysUpdate_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getStartupCardUpdateCheckAlwaysUpdate(), false);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_CardUpdateCheckInterval_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getCardUpdateCheckInterval(), 7);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_AlwaysEnableNewSets_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getAlwaysEnableNewSets(), false);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_NotifyAboutUpdates_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getNotifyAboutUpdates(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_NotifyAboutNewVersion_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getNotifyAboutNewVersion(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Updates_UpdateReleaseChannelIndex_Default)
+{
+    UpdatesSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getUpdateReleaseChannelIndex(), 0);
+}
+
+// --- SoundSettings ---
+
+TEST_F(SettingsDefaultsTest, Sound_SoundEnabled_Default)
+{
+    SoundSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getSoundEnabled(), false);
+}
+
+TEST_F(SettingsDefaultsTest, Sound_MasterVolume_Default)
+{
+    SoundSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getMasterVolume(), 100);
+}
+
+TEST_F(SettingsDefaultsTest, Sound_MasterVolume_SetAndGet)
+{
+    SoundSettings s(settingsPath, nullptr);
+    s.setMasterVolume(50);
+    ASSERT_EQ(s.getMasterVolume(), 50);
+}
+
+// --- TabsSettings ---
+
+TEST_F(SettingsDefaultsTest, Tabs_AllTabsOpen_Default)
+{
+    TabsSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getTabVisualDeckStorageOpen(), true);
+    ASSERT_EQ(s.getTabServerOpen(), true);
+    ASSERT_EQ(s.getTabAccountOpen(), true);
+    ASSERT_EQ(s.getTabDeckStorageOpen(), true);
+    ASSERT_EQ(s.getTabReplaysOpen(), true);
+    ASSERT_EQ(s.getTabAdminOpen(), true);
+    ASSERT_EQ(s.getTabLogOpen(), true);
+}
+
+// --- ChatSettings ---
+
+TEST_F(SettingsDefaultsTest, Chat_Mention_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatMention(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_MentionCompleter_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatMentionCompleter(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_MentionColor_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatMentionColor(), QString("A6120D"));
+}
+
+TEST_F(SettingsDefaultsTest, Chat_HighlightColor_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatHighlightColor(), QString("A6120D"));
+}
+
+TEST_F(SettingsDefaultsTest, Chat_MentionForeground_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatMentionForeground(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_HighlightForeground_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getChatHighlightForeground(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_ShowMessagePopup_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getShowMessagePopup(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_ShowMentionPopup_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getShowMentionPopup(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Chat_RoomHistory_Default)
+{
+    ChatSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getRoomHistory(), true);
+}
+
+// --- PersonalSettings ---
+
+TEST_F(SettingsDefaultsTest, Personal_Lang_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getLang(), QString(""));
+}
+
+TEST_F(SettingsDefaultsTest, Personal_ClientID_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getClientID(), QString("notset"));
+}
+
+TEST_F(SettingsDefaultsTest, Personal_KeepAlive_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getKeepAlive(), 3);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_TimeOut_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getTimeOut(), 5);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_PicDownload_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getPicDownload(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_ShowStatusBar_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getShowStatusBar(), false);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_MaxFontSize_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getMaxFontSize(), 12);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_HomeTabBackgroundSource_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getHomeTabBackgroundSource(), QString("themed"));
+}
+
+TEST_F(SettingsDefaultsTest, Personal_HomeTabDisplayCardName_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getHomeTabDisplayCardName(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_ShowTipsOnStartup_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getShowTipsOnStartup(), true);
+}
+
+TEST_F(SettingsDefaultsTest, Personal_DownloadSpoilersStatus_Default)
+{
+    PersonalSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getDownloadSpoilersStatus(), false);
+}
+
+// --- VisualDeckStorageSettings ---
+
+TEST_F(SettingsDefaultsTest, VisualDeckStorage_SortingOrder_Default)
+{
+    VisualDeckStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getVisualDeckStorageSortingOrder(), 0);
+}
+
+TEST_F(SettingsDefaultsTest, VisualDeckStorage_ShowFolders_Default)
+{
+    VisualDeckStorageSettings s(settingsPath, nullptr);
+    ASSERT_EQ(s.getVisualDeckStorageShowFolders(), true);
+}
+
+TEST_F(SettingsDefaultsTest, VisualDeckStorage_DefaultTagsList_NotEmpty)
+{
+    VisualDeckStorageSettings s(settingsPath, nullptr);
+    ASSERT_GT(s.getVisualDeckStorageDefaultTagsList().size(), 0);
+}
+
+TEST_F(SettingsDefaultsTest, VisualDeckStorage_DefaultTagsList_SetAndGet)
+{
+    VisualDeckStorageSettings s(settingsPath, nullptr);
+    QStringList custom = {"Tag1", "Tag2"};
+    s.setVisualDeckStorageDefaultTagsList(custom);
+    ASSERT_EQ(s.getVisualDeckStorageDefaultTagsList(), custom);
+}
+
+} // namespace
+
+int main(int argc, char **argv)
+{
+    ::testing::InitGoogleTest(&argc, argv);
+    return RUN_ALL_TESTS();
+}