From 1329da6980fc5555b69c9dae949dc82eea0603f3 Mon Sep 17 00:00:00 2001
From: RickyRister <ricky.rister.wang@gmail.com>
Date: Sat, 8 Feb 2025 16:06:56 -0800
Subject: [PATCH] rename sort method and leave comment

---
 .../visual_deck_storage_sort_widget.cpp           | 15 +++++++++------
 .../visual_deck_storage_sort_widget.h             |  2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.cpp b/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.cpp
index 8b5356c08..dce95444d 100644
--- a/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.cpp
+++ b/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.cpp
@@ -70,17 +70,22 @@ void VisualDeckStorageSortWidget::sortFolder(VisualDeckStorageFolderDisplayWidge
     for (auto widget : children) {
         auto deckPreviewWidgets =
             widget->findChildren<DeckPreviewWidget *>(QString(), Qt::FindChildOption::FindDirectChildrenOnly);
-        auto newOrder = filterFiles(deckPreviewWidgets);
-        for (DeckPreviewWidget *previewWidget : newOrder) {
+        sortDecks(deckPreviewWidgets);
+        for (DeckPreviewWidget *previewWidget : deckPreviewWidgets) {
             folderWidget->getFlowWidget()->removeWidget(previewWidget);
         }
-        for (DeckPreviewWidget *previewWidget : newOrder) {
+        for (DeckPreviewWidget *previewWidget : deckPreviewWidgets) {
             folderWidget->getFlowWidget()->addWidget(previewWidget);
         }
     }
 }
 
-QList<DeckPreviewWidget *> VisualDeckStorageSortWidget::filterFiles(QList<DeckPreviewWidget *> widgets)
+/**
+ * Sorts the DeckPreviewWidget list in-place, using the currently selected sortOrder
+ *
+ * @param widgets The list of widgets to sort
+ */
+void VisualDeckStorageSortWidget::sortDecks(QList<DeckPreviewWidget *> widgets)
 {
     // Sort the widgets list based on the current sort order
     std::sort(widgets.begin(), widgets.end(), [this](DeckPreviewWidget *widget1, DeckPreviewWidget *widget2) {
@@ -107,6 +112,4 @@ QList<DeckPreviewWidget *> VisualDeckStorageSortWidget::filterFiles(QList<DeckPr
 
         return false; // Default case, no sorting applied
     });
-
-    return widgets;
 }
diff --git a/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.h b/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.h
index 1aac55d2d..c6e32b5a5 100644
--- a/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.h
+++ b/cockatrice/src/client/ui/widgets/visual_deck_storage/visual_deck_storage_sort_widget.h
@@ -19,7 +19,7 @@ public:
     void updateSortOrder();
     void sortFolder(VisualDeckStorageFolderDisplayWidget *folderWidget);
     QString getSearchText();
-    QList<DeckPreviewWidget *> filterFiles(QList<DeckPreviewWidget *> widgets);
+    void sortDecks(QList<DeckPreviewWidget *> widgets);
 
 signals:
     void sortOrderChanged();