jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-24 10:23:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[Windows] Pass the install dir to PowerShell without quoting pitfalls

Browse source
This commit is contained in:
Lukas Brübach 2026-09-21 18:45:10 +02:00 • committed by GitHub
parent 56fd17c19c
commit 1d3e378e96
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

27
cmake/NSIS.template.in
View file

@ -225,12 +225,17 @@ FunctionEnd
; as accepted by Get-Process -Name), call this, result in $R0 ; as accepted by Get-Process -Name), call this, result in $R0
; (1 = running from $INSTDIR, 0 = not running) ; (1 = running from $INSTDIR, 0 = not running)
Function IsAppRunning Function IsAppRunning
; Pass the install dir to PowerShell via an environment variable so it
; never has to be embedded into the -Command string: apostrophes in a path
; would terminate the command early, and `$INSTDIR` in a -like pattern
; would treat [ and ] as wildcard characters.
System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
; Exit the process explicitly so nsExec's pop reflects whether a matching ; Exit the process explicitly so nsExec's pop reflects whether a matching
; process was found: powershell.exe exits 0 whether or not the pipeline ; process was found: powershell.exe exits 0 whether or not the pipeline
; produced objects. Any other result (exit 1, or nsExec's "error" string ; produced objects. Any other result (exit 1, or nsExec's "error" string
; when powershell itself cannot be started) is treated as "running" so the ; when powershell itself cannot be started) is treated as "running" so the
; lock guard fails closed. ; lock guard fails closed.
nsExec::ExecToLog 'powershell -NoProfile -Command "if (Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | Select-Object -First 1) { exit 1 } else { exit 0 }"' nsExec::ExecToLog 'powershell -NoProfile -Command "if (Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | Select-Object -First 1) { exit 1 } else { exit 0 }"'
Pop $R0 Pop $R0
${If} $R0 == "0" ${If} $R0 == "0"
StrCpy $R0 0 StrCpy $R0 0
@ -241,12 +246,14 @@ FunctionEnd
Function CloseMatchingApps Function CloseMatchingApps
; gracefully ask every matching instance to close (sends WM_CLOSE) ; gracefully ask every matching instance to close (sends WM_CLOSE)
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | ForEach-Object { $$null = $$_.CloseMainWindow() }"' System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | ForEach-Object { $$null = $$_.CloseMainWindow() }"'
Pop $R3 Pop $R3
FunctionEnd FunctionEnd
Function ForceCloseMatchingApps Function ForceCloseMatchingApps
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | Stop-Process -Force -ErrorAction SilentlyContinue"' System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | Stop-Process -Force"'
Pop $R3 Pop $R3
FunctionEnd FunctionEnd
@ -308,12 +315,17 @@ FunctionEnd
; Uninstaller copies of the same routines (the uninstaller gets its own ; Uninstaller copies of the same routines (the uninstaller gets its own
; function set compiled in, it cannot call the installer functions). ; function set compiled in, it cannot call the installer functions).
Function un.IsAppRunning Function un.IsAppRunning
; Pass the install dir to PowerShell via an environment variable so it
; never has to be embedded into the -Command string: apostrophes in a path
; would terminate the command early, and `$INSTDIR` in a -like pattern
; would treat [ and ] as wildcard characters.
System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
; Exit the process explicitly so nsExec's pop reflects whether a matching ; Exit the process explicitly so nsExec's pop reflects whether a matching
; process was found: powershell.exe exits 0 whether or not the pipeline ; process was found: powershell.exe exits 0 whether or not the pipeline
; produced objects. Any other result (exit 1, or nsExec's "error" string ; produced objects. Any other result (exit 1, or nsExec's "error" string
; when powershell itself cannot be started) is treated as "running" so the ; when powershell itself cannot be started) is treated as "running" so the
; lock guard fails closed. ; lock guard fails closed.
nsExec::ExecToLog 'powershell -NoProfile -Command "if (Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | Select-Object -First 1) { exit 1 } else { exit 0 }"' nsExec::ExecToLog 'powershell -NoProfile -Command "if (Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | Select-Object -First 1) { exit 1 } else { exit 0 }"'
Pop $R0 Pop $R0
${If} $R0 == "0" ${If} $R0 == "0"
StrCpy $R0 0 StrCpy $R0 0
@ -323,12 +335,15 @@ Function un.IsAppRunning
FunctionEnd FunctionEnd
Function un.CloseMatchingApps Function un.CloseMatchingApps
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | ForEach-Object { $$null = $$_.CloseMainWindow() }"' ; gracefully ask every matching instance to close (sends WM_CLOSE)
System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | ForEach-Object { $$null = $$_.CloseMainWindow() }"'
Pop $R3 Pop $R3
FunctionEnd FunctionEnd
Function un.ForceCloseMatchingApps Function un.ForceCloseMatchingApps
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like $\'$INSTDIR\*$\' } | Stop-Process -Force -ErrorAction SilentlyContinue"' System::Call 'kernel32::SetEnvironmentVariable(t, t) i ("COCKATRICE_INSTDIR", "$INSTDIR")'
nsExec::ExecToLog 'powershell -NoProfile -Command "Get-Process -Name $\'$R2$\' -ErrorAction SilentlyContinue | Where-Object { $$_.Path.StartsWith($$env:COCKATRICE_INSTDIR, [StringComparison]::OrdinalIgnoreCase) } | Stop-Process -Force"'
Pop $R3 Pop $R3
FunctionEnd FunctionEnd