From 1da0c6c7a5915694ebfffb20954297483ec46b38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 18 Oct 2026 13:10:41 +0200 Subject: [PATCH] [CrashReporting] Document reporting modes on the enum per review --- .../widgets/settings_page/general_settings_page.cpp | 3 +-- .../libcockatrice/settings/personal_settings.h | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/cockatrice/src/interface/widgets/settings_page/general_settings_page.cpp b/cockatrice/src/interface/widgets/settings_page/general_settings_page.cpp index 8131ed188..a19417661 100644 --- a/cockatrice/src/interface/widgets/settings_page/general_settings_page.cpp +++ b/cockatrice/src/interface/widgets/settings_page/general_settings_page.cpp @@ -133,8 +133,7 @@ GeneralSettingsPage::GeneralSettingsPage() versionGroupBox = new QGroupBox; versionGroupBox->setLayout(versionGrid); - // crash reporting consent (lives in personal.ini, not debug.ini): Ask shows the crash dialog - // after an unclean exit, AlwaysSend uploads without asking, NeverSend stays silent. + // crash reporting consent (stored in personal.ini, not debug.ini) crashReportingBox.addItem(""); // texts set in retranslateUi crashReportingBox.addItem(""); crashReportingBox.addItem(""); diff --git a/libcockatrice_settings/libcockatrice/settings/personal_settings.h b/libcockatrice_settings/libcockatrice/settings/personal_settings.h index c202585ef..0cd51cdd0 100644 --- a/libcockatrice_settings/libcockatrice/settings/personal_settings.h +++ b/libcockatrice_settings/libcockatrice/settings/personal_settings.h @@ -26,9 +26,9 @@ public: enum class CrashReportingMode { - Ask = 0, - AlwaysSend = 1, - NeverSend = 2 + Ask = 0, ///< Show the crash-report dialog after an unclean exit. + AlwaysSend = 1, ///< Upload crash reports without asking. + NeverSend = 2 ///< Never upload; stay silent. }; [[nodiscard]] CrashReportingMode getCrashReportingMode() const;