From 24708522f4125cb2f76c03d741fff60d18bfc3ad Mon Sep 17 00:00:00 2001 From: RickyRister Date: Sat, 12 Jul 2025 03:57:33 -0700 Subject: [PATCH] early returns --- cockatrice/src/game/cards/card_database.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/cockatrice/src/game/cards/card_database.cpp b/cockatrice/src/game/cards/card_database.cpp index fdd43fbf4..b8873c7d2 100644 --- a/cockatrice/src/game/cards/card_database.cpp +++ b/cockatrice/src/game/cards/card_database.cpp @@ -397,15 +397,16 @@ PrintingInfo CardDatabase::getSpecificPrinting(const QString &cardName, QString CardDatabase::getPreferredPrintingProviderIdForCard(const QString &cardName) { PrintingInfo preferredPrinting = getPreferredPrinting(cardName); - QString preferredPrintingProviderId = preferredPrinting.getProperty(QString("uuid")); - if (preferredPrintingProviderId.isEmpty()) { - CardInfoPtr defaultCardInfo = getCard(cardName); - if (defaultCardInfo.isNull()) { - return cardName; - } - return defaultCardInfo->getName(); + QString uuid = preferredPrinting.getProperty("uuid"); + if (!uuid.isEmpty()) { + return uuid; } - return preferredPrintingProviderId; + + CardInfoPtr defaultCardInfo = getCard(cardName); + if (defaultCardInfo.isNull()) { + return cardName; + } + return defaultCardInfo->getName(); } bool CardDatabase::isProviderIdForPreferredPrinting(const QString &cardName, const QString &providerId)