From 268a32464c6f32381a0d563d38f2c052ffc6dba2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <44814898+BruebachL@users.noreply.github.com> Date: Sat, 7 Nov 2026 11:00:28 +0100 Subject: [PATCH] [Icons] Show the trash can with the sticker treatment again The sticker sheet kept the delete glyph out of the sticker rows and explained why: at toolbar sizes the rim closed the lid gap. The icon is used with the sticker treatment again for destructive actions, so the sheet now shows it and the exception note is gone. --- tests/theme_migration/theme_icon_render_test.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/theme_migration/theme_icon_render_test.cpp b/tests/theme_migration/theme_icon_render_test.cpp index f9f4d669c..ee078555d 100644 --- a/tests/theme_migration/theme_icon_render_test.cpp +++ b/tests/theme_migration/theme_icon_render_test.cpp @@ -859,6 +859,7 @@ TEST(IconStickerPreview, WritesPngsWhenRequested) {"increment", AppColor::Positive}, {"decrement", AppColor::Negative}, {"remove_row", AppColor::Negative}, + {"delete", AppColor::Negative}, }; constexpr int SIZES[] = {15, 16, 24, 48}; constexpr int CONTEXT_SIZE = 32; @@ -888,7 +889,7 @@ TEST(IconStickerPreview, WritesPngsWhenRequested) const int logicalWidth = MARGIN + LABEL_WIDTH + static_cast(std::size(SIZES)) * CELL_WIDTH + MARGIN; const int logicalHeight = MARGIN + 24 + 24 + static_cast(std::size(stickered)) * GLYPH_BLOCK_HEIGHT + 24 + 24 + - CONTEXT_SIZE + 46 + CONTEXT_SIZE + 46 + 20 + MARGIN; + CONTEXT_SIZE + 46 + CONTEXT_SIZE + 46 + MARGIN; const QSize imageSize(qRound(logicalWidth * DPR), qRound(logicalHeight * DPR)); for (const bool dark : {false, true}) { @@ -978,12 +979,6 @@ TEST(IconStickerPreview, WritesPngsWhenRequested) } } - y += CONTEXT_SIZE + 46; - painter.drawText( - QPointF(MARGIN, y), - QStringLiteral( - "The clear-filter trash can keeps the line treatment; a sticker rim closes its lid at toolbar sizes.")); - painter.end(); const QString path = QDir(outDir).absoluteFilePath(dark ? QStringLiteral("sticker-preview-dark.png") : QStringLiteral("sticker-preview-light.png"));