jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-15 11:38:49 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

join game error dialog

Browse source
This commit is contained in:
seavor 2026-04-20 00:25:10 -05:00
parent db1530c9e9
commit 2aeb1542b1
20 changed files with 415 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

39
webclient/src/containers/Room/GameSelector/GameSelector.spec.tsx
View file

@ -55,6 +55,7 @@ function buildState(
room: ReturnType<typeof makeRoomEntry>,
user = makeUser(),
selectedGameId?: number,
roomsOverrides: Partial<{ joinGamePending: boolean; joinGameError: { code: number; message: string } | null }> = {},
) {
return makeStoreState({
...connectedWithRoomsState,
@ -67,6 +68,9 @@ function buildState(
sortUsersBy: { field: App.UserSortField.NAME, order: App.SortDirection.ASC },
selectedGameIds: selectedGameId != null ? { 1: selectedGameId } : {},
gameFilters: {},
joinGamePending: false,
joinGameError: null,
...roomsOverrides,
} as any,
server: {
...(connectedWithRoomsState.server as any),
@ -181,6 +185,41 @@ describe('GameSelector', () => {
expect(screen.getByRole('button', { name: /Join as Judge Spectator/i })).toBeInTheDocument();
});
it('renders AlertDialog with the join error message from state', () => {
mockUseWebClient.mockReturnValue(makeWebClient());
const room = makeRoomEntry([]);
renderWithProviders(<GameSelector room={room as any} />, {
preloadedState: buildState(room, makeUser(), undefined, {
joinGameError: { code: 10, message: 'The game is already full.' },
}),
});
expect(screen.getByText('Error')).toBeInTheDocument();
expect(screen.getByText('The game is already full.')).toBeInTheDocument();
expect(screen.getByRole('button', { name: /^ok$/i })).toBeInTheDocument();
});
it('does not render AlertDialog when joinGameError is null (covers silent RespContextError)', () => {
mockUseWebClient.mockReturnValue(makeWebClient());
const room = makeRoomEntry([]);
renderWithProviders(<GameSelector room={room as any} />, {
preloadedState: buildState(room, makeUser(), undefined, { joinGameError: null }),
});
// Only the CreateGame / FilterGames / PromptDialog / AlertDialog dialogs might exist; none
// should be open, so no role="dialog" in the DOM.
expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
});
it('Join button is disabled while joinGamePending is true even when a game is selected', () => {
mockUseWebClient.mockReturnValue(makeWebClient());
const game = makeGame({ gameId: 7 });
const room = makeRoomEntry([game]);
renderWithProviders(<GameSelector room={room as any} />, {
preloadedState: buildState(room, makeUser(), 7, { joinGamePending: true }),
});
expect(screen.getByRole('button', { name: /^Join$/ })).toBeDisabled();
expect(screen.getByRole('button', { name: /Join as Spectator/i })).toBeDisabled();
});
it('clicking Create then submitting forwards createGame', () => {
const client = makeWebClient();
mockUseWebClient.mockReturnValue(client);