delete overloaded signal in PendingCommand (#5477)

* remove overloaded signal since no one was using it

* remove usages of qOverload

* turns out new slot/signal syntax can ignore extra params

cockatrice/src/client/tabs/tab_account.cpp

@@ -39,10 +39,7 @@ TabAccount::TabAccount(TabSupervisor *_tabSupervisor, AbstractClient *_client, c
     connect(client, &AbstractClient::removeFromListEventReceived, this, &TabAccount::processRemoveFromListEvent);
 
     PendingCommand *pend = client->prepareSessionCommand(Command_ListUsers());
-    connect(pend,
+    connect(pend, &PendingCommand::finished, this, &TabAccount::processListUsersResponse);
-            static_cast<void (PendingCommand::*)(const Response &, const CommandContainer &, const QVariant &)>(
-                &PendingCommand::finished),
-            this, &TabAccount::processListUsersResponse);
     client->sendCommand(pend);
 
     QVBoxLayout *vbox = new QVBoxLayout;

cockatrice/src/client/tabs/tab_admin.cpp

@@ -170,9 +170,7 @@ void TabAdmin::actGrantReplayAccess()
     cmd.set_moderator_name(client->getUserName().toStdString());
 
     auto *pend = client->prepareModeratorCommand(cmd);
-    connect(pend,
+    connect(pend, &PendingCommand::finished, this, &TabAdmin::grantReplayAccessProcessResponse);
-            QOverload<const Response &, const CommandContainer &, const QVariant &>::of(&PendingCommand::finished),
-            this, &TabAdmin::grantReplayAccessProcessResponse);
     client->sendCommand(pend);
 }
 
@@ -193,7 +191,7 @@ void TabAdmin::actForceActivateUser()
     client->sendCommand(pend);
 }
 
-void TabAdmin::grantReplayAccessProcessResponse(const Response &response, const CommandContainer &, const QVariant &)
+void TabAdmin::grantReplayAccessProcessResponse(const Response &response)
 {
     auto *event = new Event_ReplayAdded();
 
@@ -211,7 +209,7 @@ void TabAdmin::grantReplayAccessProcessResponse(const Response &response, const
     }
 }
 
-void TabAdmin::activateUserProcessResponse(const Response &response, const CommandContainer &, const QVariant &)
+void TabAdmin::activateUserProcessResponse(const Response &response)
 {
     switch (response.response_code()) {
         case Response::RespActivationAccepted:

cockatrice/src/client/tabs/tab_admin.h

@@ -47,8 +47,8 @@ private slots:
     void actReloadConfig();
     void actGrantReplayAccess();
     void actForceActivateUser();
-    void grantReplayAccessProcessResponse(const Response &resp, const CommandContainer &, const QVariant &);
+    void grantReplayAccessProcessResponse(const Response &response);
-    void activateUserProcessResponse(const Response &response, const CommandContainer &, const QVariant &);
+    void activateUserProcessResponse(const Response &response);
 
     void actUnlock();
     void actLock();

cockatrice/src/game/game_selector.cpp

@@ -194,9 +194,7 @@ void GameSelector::actCreate()
     updateTitle();
 }
 
-void GameSelector::checkResponse(const Response &response,
+void GameSelector::checkResponse(const Response &response)
-                                 const CommandContainer & /* commandContainer */,
-                                 const QVariant & /* extraData */)
 {
     // NB: We re-enable buttons for the currently selected game, which may not
     // be the same game as the one for which we are processing a response.
@@ -274,8 +272,7 @@ void GameSelector::actJoin()
     }
 
     PendingCommand *pend = r->prepareRoomCommand(cmd);
-    connect(pend, qOverload<const Response &, const CommandContainer &, const QVariant &>(&PendingCommand::finished),
+    connect(pend, &PendingCommand::finished, this, &GameSelector::checkResponse);
-            this, &GameSelector::checkResponse);
     r->sendRoomCommand(pend);
 
     disableButtons();

cockatrice/src/game/game_selector.h

@@ -29,7 +29,7 @@ private slots:
     void actCreate();
     void actJoin();
     void actSelectedGameChanged(const QModelIndex &current, const QModelIndex &previous);
-    void checkResponse(const Response &response, const CommandContainer &, const QVariant &);
+    void checkResponse(const Response &response);
 
     void ignoreListReceived(const QList<ServerInfo_User> &_ignoreList);
     void processAddToListEvent(const Event_AddToList &event);

cockatrice/src/game/zones/view_zone.cpp

@@ -77,9 +77,7 @@ void ZoneViewZone::initializeCards(const QList<const ServerInfo_Card *> &cardLis
         cmd.set_is_reversed(isReversed);
 
         PendingCommand *pend = player->prepareGameCommand(cmd);
-        connect(pend,
+        connect(pend, &PendingCommand::finished, this, &ZoneViewZone::zoneDumpReceived);
-                qOverload<const Response &, const CommandContainer &, const QVariant &>(&PendingCommand::finished),
-                this, &ZoneViewZone::zoneDumpReceived);
         player->sendGameCommand(pend);
     } else {
         const CardList &c = origZone->getCards();
@@ -93,9 +91,7 @@ void ZoneViewZone::initializeCards(const QList<const ServerInfo_Card *> &cardLis
     }
 }
 
-void ZoneViewZone::zoneDumpReceived(const Response &r,
+void ZoneViewZone::zoneDumpReceived(const Response &r)
-                                    const CommandContainer & /* commandContainer */,
-                                    const QVariant & /* extraData */)
 {
     const Response_DumpZone &resp = r.GetExtension(Response_DumpZone::ext);
     const int respCardListSize = resp.zone_info().card_list_size();

cockatrice/src/game/zones/view_zone.h

@@ -95,7 +95,7 @@ public slots:
     void setSortBy(CardList::SortOption _sortBy);
     void setPileView(int _pileView);
 private slots:
-    void zoneDumpReceived(const Response &r, const CommandContainer &, const QVariant &);
+    void zoneDumpReceived(const Response &r);
 signals:
     void beingDeleted();
     void optimumRectChanged();

cockatrice/src/server/pending_command.cpp

@@ -23,7 +23,6 @@ QVariant PendingCommand::getExtraData() const
 void PendingCommand::processResponse(const Response &response)
 {
     emit finished(response, commandContainer, extraData);
-    emit finished(response.response_code());
 }
 
 int PendingCommand::tick()

cockatrice/src/server/pending_command.h

@@ -11,7 +11,6 @@ class PendingCommand : public QObject
     Q_OBJECT
 signals:
     void finished(const Response &response, const CommandContainer &commandContainer, const QVariant &extraData);
-    void finished(Response::ResponseCode respCode);
 
 private:
     CommandContainer commandContainer;

cockatrice/src/server/user/user_info_box.cpp

@@ -250,17 +250,14 @@ void UserInfoBox::actPassword()
         cmd.set_user_name(client->getUserName().toStdString());
 
         PendingCommand *pend = client->prepareSessionCommand(cmd);
-        connect(pend,
+        connect(pend, &PendingCommand::finished, this, [=, this](const Response &response) {
-                // we need qoverload here in order to select the right version of this function
+            if (response.response_code() == Response::RespOk) {
-                QOverload<const Response &, const CommandContainer &, const QVariant &>::of(&PendingCommand::finished),
+                changePassword(oldPassword, newPassword);
-                this, [=, this](const Response &response, const CommandContainer &, const QVariant &) {
+            } else {
-                    if (response.response_code() == Response::RespOk) {
+                QMessageBox::critical(this, tr("Error"),
-                        changePassword(oldPassword, newPassword);
+                                      tr("An error occurred while trying to update your user information."));
-                    } else {
+            }
-                        QMessageBox::critical(this, tr("Error"),
+        });
-                                              tr("An error occurred while trying to update your user information."));
-                    }
-                });
         client->sendCommand(pend);
     } else {
         changePassword(oldPassword, newPassword);

cockatrice/src/server/user/user_list_manager.cpp

@@ -51,8 +51,7 @@ void UserListManager::setOwnUserInfo(const ServerInfo_User &userInfo)
 void UserListManager::populateInitialOnlineUsers()
 {
     PendingCommand *pend = client->prepareSessionCommand(Command_ListUsers());
-    connect(pend, qOverload<const Response &, const CommandContainer &, const QVariant &>(&PendingCommand::finished),
+    connect(pend, &PendingCommand::finished, this, &UserListManager::processListUsersResponse);
-            this, &UserListManager::processListUsersResponse);
     client->sendCommand(pend);
 }