From 32d13062ffe76853d303ec84a89e5e28bd4fd89a Mon Sep 17 00:00:00 2001
From: RickyRister <ricky.rister.wang@gmail.com>
Date: Tue, 5 Aug 2025 23:14:19 -0300
Subject: [PATCH] delete TabGame::updateCardMenu

---
 cockatrice/src/client/tabs/tab_game.cpp | 17 -----------------
 cockatrice/src/client/tabs/tab_game.h   |  1 -
 cockatrice/src/game/board/card_item.cpp |  2 +-
 3 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/cockatrice/src/client/tabs/tab_game.cpp b/cockatrice/src/client/tabs/tab_game.cpp
index 7c112e3e0..3a81795c4 100644
--- a/cockatrice/src/client/tabs/tab_game.cpp
+++ b/cockatrice/src/client/tabs/tab_game.cpp
@@ -1218,23 +1218,6 @@ Player *TabGame::getActiveLocalPlayer() const
 void TabGame::setActiveCard(CardItem *card)
 {
     activeCard = card;
-    updateCardMenu(card);
-}
-
-void TabGame::updateCardMenu(AbstractCardItem *card)
-{
-    if (card == nullptr) {
-        return;
-    }
-    Player *player;
-    if ((clients.size() > 1) || !players.contains(localPlayerId)) {
-        player = card->getOwner();
-    } else {
-        player = players.value(localPlayerId);
-    }
-    if (player != nullptr) {
-        player->updateCardMenu(static_cast<CardItem *>(card));
-    }
 }
 
 /**
diff --git a/cockatrice/src/client/tabs/tab_game.h b/cockatrice/src/client/tabs/tab_game.h
index 0172d1022..96e902c2e 100644
--- a/cockatrice/src/client/tabs/tab_game.h
+++ b/cockatrice/src/client/tabs/tab_game.h
@@ -172,7 +172,6 @@ private slots:
     void incrementGameTime();
     void adminLockChanged(bool lock);
     void newCardAdded(AbstractCardItem *card);
-    void updateCardMenu(AbstractCardItem *card);
     void setCardMenu(QMenu *menu);
 
     void actGameInfo();
diff --git a/cockatrice/src/game/board/card_item.cpp b/cockatrice/src/game/board/card_item.cpp
index d22a50b40..500fd67bd 100644
--- a/cockatrice/src/game/board/card_item.cpp
+++ b/cockatrice/src/game/board/card_item.cpp
@@ -466,8 +466,8 @@ QVariant CardItem::itemChange(GraphicsItemChange change, const QVariant &value)
 {
     if ((change == ItemSelectedHasChanged) && owner != nullptr) {
         if (value == true) {
-            owner->updateCardMenu(this);
             owner->getGame()->setActiveCard(this);
+            owner->updateCardMenu(this);
         }
     }
     return AbstractCardItem::itemChange(change, value);