jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-04-27 07:48:01 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Close the TabGames when closing the TabSupervisor (#5735)

Browse source 
* Close the `TabGame`s when closing the `TabSupervisor`

This ensures that we go through the same code path (in terms of Qt
events) when closing the whole supervisor as when closing a single tab.
Also, use the `close` event instead of the `hide` event to detect when
we are closing a game.

Fixes #5697

* Compat with old Qt versions

* Old Qt, reloaded

* Review: use hideEvent and call super
This commit is contained in:
Basile Clement 2025-03-17 00:05:04 +01:00 • committed by GitHub
parent 57a8960841
commit 37382dea44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 47 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cockatrice/src/client/ui/window_main.cpp
View file

@ -1018,7 +1018,7 @@ void MainWindow::closeEvent(QCloseEvent *event)
return;
bClosingDown = true;
if (!tabSupervisor->closeRequest()) {
if (!tabSupervisor->close()) {
event->ignore();
bClosingDown = false;
return;