Only link Qt::Core instead of COCKATRICE_QT_MODULES to libraries, if possible.

Took 2 minutes
This commit is contained in:
Lukas Brübach 2025-11-05 18:43:53 +01:00
parent 3accb47e29
commit 396eecdece
4 changed files with 4 additions and 8 deletions

View file

@ -52,5 +52,5 @@ target_include_directories(
target_link_libraries( target_link_libraries(
libcockatrice_card libcockatrice_card
PUBLIC libcockatrice_settings PUBLIC libcockatrice_settings
PUBLIC ${COCKATRICE_QT_MODULES} PUBLIC ${QT_CORE_MODULE}
) )

View file

@ -25,6 +25,4 @@ add_dependencies(libcockatrice_deck_list libcockatrice_protocol)
target_include_directories(libcockatrice_deck_list PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}) target_include_directories(libcockatrice_deck_list PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries( target_link_libraries(libcockatrice_deck_list PUBLIC libcockatrice_protocol libcockatrice_utility ${QT_CORE_MODULE})
libcockatrice_deck_list PUBLIC libcockatrice_protocol libcockatrice_utility ${COCKATRICE_QT_MODULES}
)

View file

@ -17,9 +17,7 @@ target_sources(libcockatrice_protocol PRIVATE ${SOURCES} ${HEADERS})
add_dependencies(libcockatrice_protocol libcockatrice_protocol_pb) add_dependencies(libcockatrice_protocol libcockatrice_protocol_pb)
# Link the actual generated protobuf library # Link the actual generated protobuf library
target_link_libraries( target_link_libraries(libcockatrice_protocol PUBLIC ${QT_CORE_MODULE} libcockatrice_protocol_pb libcockatrice_utility)
libcockatrice_protocol PUBLIC ${COCKATRICE_QT_MODULES} libcockatrice_protocol_pb libcockatrice_utility
)
# Expose include paths # Expose include paths
target_include_directories( target_include_directories(

View file

@ -17,4 +17,4 @@ add_library(
target_include_directories(libcockatrice_rng PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}) target_include_directories(libcockatrice_rng PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries(libcockatrice_rng PUBLIC ${COCKATRICE_QT_MODULES}) target_link_libraries(libcockatrice_rng PUBLIC ${QT_CORE_MODULE})