From 40a482686d6fff2846d12099e0894b9462d99f29 Mon Sep 17 00:00:00 2001
From: RickyRister <ricky.rister.wang@gmail.com>
Date: Fri, 3 Jan 2025 18:59:49 -0800
Subject: [PATCH] refactor

---
 cockatrice/src/game/zones/view_zone.cpp | 10 ++++++++--
 cockatrice/src/game/zones/view_zone.h   |  2 ++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/cockatrice/src/game/zones/view_zone.cpp b/cockatrice/src/game/zones/view_zone.cpp
index f64dcf23a..333073a70 100644
--- a/cockatrice/src/game/zones/view_zone.cpp
+++ b/cockatrice/src/game/zones/view_zone.cpp
@@ -108,12 +108,12 @@ void ZoneViewZone::zoneDumpReceived(const Response &r)
         }
     }
     previousOrigSize = origZone->getCards().size();
+    updateCardIds(false);
     reorganizeCards();
     emit cardCountChanged();
 }
 
-// Because of boundingRect(), this function must not be called before the zone was added to a scene.
-void ZoneViewZone::reorganizeCards()
+void ZoneViewZone::updateCardIds(bool /*isRemoval*/)
 {
     int cardCount = cards.size();
     if (!origZone->contentsKnown()) {
@@ -138,7 +138,11 @@ void ZoneViewZone::reorganizeCards()
             cards[i]->setId(i + startId);
         }
     }
+}
 
+// Because of boundingRect(), this function must not be called before the zone was added to a scene.
+void ZoneViewZone::reorganizeCards()
+{
     CardList cardsToDisplay(cards);
 
     // sort cards
@@ -287,6 +291,7 @@ void ZoneViewZone::addCardImpl(CardItem *card, int x, int /*y*/)
     }
     card->setParentItem(this);
     card->update();
+    updateCardIds(false);
     reorganizeCards();
 }
 
@@ -325,6 +330,7 @@ void ZoneViewZone::removeCard(int position)
 
     CardItem *card = cards.takeAt(position);
     card->deleteLater();
+    updateCardIds(false);
     reorganizeCards();
 }
 
diff --git a/cockatrice/src/game/zones/view_zone.h b/cockatrice/src/game/zones/view_zone.h
index 48808a9ec..df104f2ae 100644
--- a/cockatrice/src/game/zones/view_zone.h
+++ b/cockatrice/src/game/zones/view_zone.h
@@ -38,6 +38,8 @@ private:
     int firstCardId;
     int previousOrigSize;
 
+    void updateCardIds(bool isRemoval);
+
     struct GridSize
     {
         int rows;