From 41f01ff4a907e62ccb260b0330c36d397fb4f0bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 11 Oct 2026 14:58:01 +0200 Subject: [PATCH] [Client] Restore language switching in SettingsView Deleting DlgSettings removed its updateLanguage hook, the only langChanged handler that swapped the QTranslator. SettingsView takes it over so picking a language applies immediately. --- cockatrice/src/interface/widgets/dialogs/settings_view.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cockatrice/src/interface/widgets/dialogs/settings_view.cpp b/cockatrice/src/interface/widgets/dialogs/settings_view.cpp index a6b9fc55c..a226c9a37 100644 --- a/cockatrice/src/interface/widgets/dialogs/settings_view.cpp +++ b/cockatrice/src/interface/widgets/dialogs/settings_view.cpp @@ -92,9 +92,9 @@ static QStringList pageIconResources() SettingsView::SettingsView(QWidget *parent) : QWidget(parent), currentTabIndex(0), searchActive(false) { - // Swap the QTranslator before retranslating (was DlgSettings::updateLanguage): without this, picking a new - // language only stores the setting and every retranslateUi re-runs against the old translator until restart. - // Connected before setupUi() so the swap runs before the pages' own langChanged handlers below. + // Swap the QTranslator before retranslating (was DlgSettings::updateLanguage, removed with the dialog): + // without this, picking a new language only stores the setting and every retranslateUi re-runs against the + // old translator until restart. Connected before setupUi() so the swap runs before the pages' own handlers. connect(&SettingsCache::instance().personal(), &PersonalSettings::langChanged, this, &SettingsView::updateLanguage); setupUi();