From 431afcf2972212b2bcca40fecf8652d1b21f7aab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Mon, 15 Sep 2025 00:53:21 +0200 Subject: [PATCH] Introduce isLocalPlayer convenience method. Took 21 minutes --- cockatrice/src/game/player/player_manager.cpp | 13 ++++++------- cockatrice/src/game/player/player_manager.h | 1 + 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cockatrice/src/game/player/player_manager.cpp b/cockatrice/src/game/player/player_manager.cpp index 813cdb6d1..bbe128bf8 100644 --- a/cockatrice/src/game/player/player_manager.cpp +++ b/cockatrice/src/game/player/player_manager.cpp @@ -35,6 +35,11 @@ Player *PlayerManager::getActiveLocalPlayer(int activePlayer) const return nullptr; } +bool PlayerManager::isLocalPlayer(int playerId) +{ + return game->getGameState()->getIsLocalGame() || playerId == localPlayerId; +} + Player *PlayerManager::addPlayer(int playerId, const ServerInfo_User &info) { auto *newPlayer = new Player(info, playerId, isLocalPlayer(playerId) || game->getGameState()->getIsLocalGame(), @@ -68,13 +73,7 @@ Player *PlayerManager::getPlayer(int playerId) const void PlayerManager::onPlayerConceded(int playerId, bool conceded) { // GameEventHandler cares about this for sending the concede/unconcede commands - if (game->getGameState()->getIsLocalGame()) { - if (conceded) { - emit activeLocalPlayerConceded(); - } else { - emit activeLocalPlayerUnconceded(); - } - } else if (playerId == localPlayerId) { + if (isLocalPlayer(playerId)) { if (conceded) { emit activeLocalPlayerConceded(); } else { diff --git a/cockatrice/src/game/player/player_manager.h b/cockatrice/src/game/player/player_manager.h index 92e492510..32f4a5753 100644 --- a/cockatrice/src/game/player/player_manager.h +++ b/cockatrice/src/game/player/player_manager.h @@ -48,6 +48,7 @@ public: } Player *getActiveLocalPlayer(int activePlayer) const; + bool isLocalPlayer(int playerId); Player *addPlayer(int playerId, const ServerInfo_User &info);