diff --git a/cockatrice/src/client/ui/widgets/printing_selector/printing_selector_card_overlay_widget.cpp b/cockatrice/src/client/ui/widgets/printing_selector/printing_selector_card_overlay_widget.cpp index 64f8b120c..0bc6830af 100644 --- a/cockatrice/src/client/ui/widgets/printing_selector/printing_selector_card_overlay_widget.cpp +++ b/cockatrice/src/client/ui/widgets/printing_selector/printing_selector_card_overlay_widget.cpp @@ -177,14 +177,13 @@ void PrintingSelectorCardOverlayWidget::customMenu(QPoint point) if (preferredProviderId.isEmpty() || preferredProviderId != cardProviderId) { QAction *setPreferred = preferenceMenu->addAction(tr("Set as preferred printing")); connect(setPreferred, &QAction::triggered, this, [this, cardProviderId]() { - SettingsCache::instance().cardOverrides().setCardPreferenceOverride(rootCard->getName(), cardProviderId, - true); + SettingsCache::instance().cardOverrides().setCardPreferenceOverride(rootCard->getName(), cardProviderId); emit cardPreferenceChanged(); }); } else { QAction *setUnpreferred = preferenceMenu->addAction(tr("Unset as preferred printing")); - connect(setUnpreferred, &QAction::triggered, this, [this]() { - SettingsCache::instance().cardOverrides().setCardPreferenceOverride(rootCard->getName(), "", false); + connect(setUnpreferred, &QAction::triggered, this, [this, cardProviderId]() { + SettingsCache::instance().cardOverrides().deleteCardPreferenceOverride(rootCard->getName()); emit cardPreferenceChanged(); }); } diff --git a/cockatrice/src/settings/card_override_settings.cpp b/cockatrice/src/settings/card_override_settings.cpp index 3d5b62f59..0bcdcf5e5 100644 --- a/cockatrice/src/settings/card_override_settings.cpp +++ b/cockatrice/src/settings/card_override_settings.cpp @@ -5,16 +5,17 @@ CardOverrideSettings::CardOverrideSettings(QString settingPath, QObject *parent) { } -void CardOverrideSettings::setCardPreferenceOverride(QString cardName, QString providerId, bool enabled) +void CardOverrideSettings::setCardPreferenceOverride(const QString &cardName, const QString &providerId) { - if (enabled) { - setValue(providerId, cardName, "cards"); - } else { - deleteValue(providerId, cardName, "cards"); - } + setValue(providerId, cardName, "cards"); } -QString CardOverrideSettings::getCardPreferenceOverride(QString cardName) +void CardOverrideSettings::deleteCardPreferenceOverride(const QString &cardName) +{ + deleteValue(cardName, "cards"); +} + +QString CardOverrideSettings::getCardPreferenceOverride(const QString &cardName) { return getValue(cardName, "cards").toString(); } \ No newline at end of file diff --git a/cockatrice/src/settings/card_override_settings.h b/cockatrice/src/settings/card_override_settings.h index 9f0c489eb..1f6b08817 100644 --- a/cockatrice/src/settings/card_override_settings.h +++ b/cockatrice/src/settings/card_override_settings.h @@ -11,9 +11,11 @@ class CardOverrideSettings : public SettingsManager friend class SettingsCache; public: - void setCardPreferenceOverride(QString cardName, QString providerId, bool enabled); + void setCardPreferenceOverride(const QString &cardName, const QString &providerId); - QString getCardPreferenceOverride(QString cardName); + void deleteCardPreferenceOverride(const QString &cardName); + + QString getCardPreferenceOverride(const QString &cardName); private: explicit CardOverrideSettings(QString settingPath, QObject *parent = nullptr);