jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-11-11 04:23:29 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[Oracle] Fix Scryfall tag requests and the retry loop

Browse source 
api.scryfall.com rejects requests that lack an Accept header with HTTP 400, and QNetworkAccessManager does not add one. Send application/json for the bulk metadata request and */* for the tag file, and surface the URL plus Scryfall's JSON error body when a request fails.

A failed tag load used to call next(), which re-ran validatePage() and started the same failing download again, trapping the user in an error loop. Stay on the page instead, drop the unusable database, and tell the user they can retry, change the source, or untick the option to import without tags. Also explain parent tags inline with a real Scryfall hierarchy example.
This commit is contained in:
Lukas Brübach 2026-11-08 20:13:45 +01:00
parent 6d7ac89cc5
commit 4aab93f3b6
2 changed files with 52 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
oracle/src/pages.h
View file

@ -147,6 +147,7 @@ private:
QPushButton *urlButton;
QPushButton *fileButton;
QCheckBox *parentsCheckBox;
QLabel *parentsExplainer;
QLabel *statusLabel;
QLabel *progressLabel;
QProgressBar *progressBar;