From 578c65093665330e828ff048d6b52ccc178fe5c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sat, 13 Sep 2025 11:17:16 +0200 Subject: [PATCH] Properly delete enlargedPixmapWidget. Took 23 minutes Took 13 seconds Took 16 seconds --- .../client/ui/widgets/cards/card_info_picture_widget.cpp | 7 +++---- .../src/client/ui/widgets/cards/card_info_picture_widget.h | 1 + 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp index c84f6a7d5..4e4f4b828 100644 --- a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp +++ b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp @@ -40,6 +40,8 @@ CardInfoPictureWidget::CardInfoPictureWidget(QWidget *parent, const bool _hoverT enlargedPixmapWidget = new CardInfoPictureEnlargedWidget(this->window()); enlargedPixmapWidget->hide(); + connect(this, &CardInfoPictureWidget::deleteEnlargedPixmapWidget, enlargedPixmapWidget, + &CardInfoPictureEnlargedWidget::deleteLater); hoverTimer = new QTimer(this); hoverTimer->setSingleShot(true); @@ -65,10 +67,7 @@ CardInfoPictureWidget::CardInfoPictureWidget(QWidget *parent, const bool _hoverT CardInfoPictureWidget::~CardInfoPictureWidget() { - if (enlargedPixmapWidget) { - enlargedPixmapWidget->hide(); - enlargedPixmapWidget->deleteLater(); - } + emit deleteEnlargedPixmapWidget(); } /** diff --git a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.h b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.h index 7de144a80..834141d56 100644 --- a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.h +++ b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.h @@ -40,6 +40,7 @@ signals: void cardScaleFactorChanged(int _scale); void cardChanged(const ExactCard &card); void cardClicked(); + void deleteEnlargedPixmapWidget(); protected: void resizeEvent(QResizeEvent *event) override;