jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-11-05 09:33:25 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[Client] Warn when data paths point inside the program directory (#7473)

Browse source 
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2026-10-11 15:34:49 +02:00 • committed by GitHub
parent f83a61979f
commit 57a6a0d9cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 247 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

51
tests/settings/settings_defaults_test.cpp
View file

@ -1,6 +1,7 @@
#include "libcockatrice/card/card_localization.h"
#include "gtest/gtest.h"
#include <QDir>
#include <QHash>
#include <QList>
#include <QString>
@ -15,6 +16,7 @@
#include <libcockatrice/settings/game_settings.h>
#include <libcockatrice/settings/interface_settings.h>
#include <libcockatrice/settings/network_settings.h>
#include <libcockatrice/settings/paths_settings.h>
#include <libcockatrice/settings/personal_settings.h>
#include <libcockatrice/settings/sound_settings.h>
#include <libcockatrice/settings/tabs_settings.h>
@ -695,6 +697,55 @@ TEST_F(SettingsDefaultsTest, VisualDeckStorage_ShowUploadTime_SetAndGet)
ASSERT_EQ(s.getVisualDeckStorageShowUploadTime(), false);
}
TEST_F(SettingsDefaultsTest, Paths_AppDirWarningAcknowledged_Default)
{
PathsSettings s(settingsPath, nullptr);
ASSERT_EQ(s.getAppDirWarningAcknowledged(), false);
}
TEST_F(SettingsDefaultsTest, Paths_AppDirWarningAcknowledged_SetAndGet)
{
PathsSettings s(settingsPath, nullptr);
s.setAppDirWarningAcknowledged(true);
ASSERT_EQ(s.getAppDirWarningAcknowledged(), true);
}
TEST_F(SettingsDefaultsTest, Paths_PathsInsideDir_DetectsNestedAndIgnoresSiblings)
{
PathsSettings s(settingsPath, nullptr);
const QString base = QDir::cleanPath(settingsPath);
s.setDeckPath(base + "/decks/");
s.setPicsPath(base + "/pics");
s.setReplaysPath(base + "2"); // sibling sharing the name prefix, not nested
const QStringList offenders = s.pathsInsideDir(base);
ASSERT_EQ(offenders.size(), 2);
ASSERT_TRUE(offenders.contains(base + "/decks"));
ASSERT_TRUE(offenders.contains(base + "/pics"));
}
TEST_F(SettingsDefaultsTest, Paths_PathsInsideDir_EmptyWhenNothingMatches)
{
PathsSettings s(settingsPath, nullptr);
s.setDeckPath("/somewhere/else/decks");
ASSERT_TRUE(s.pathsInsideDir(QDir::cleanPath(settingsPath)).isEmpty());
}
TEST_F(SettingsDefaultsTest, Paths_PathsInsideDir_MatchesExactBaseAndNormalizesDots)
{
PathsSettings s(settingsPath, nullptr);
const QString base = QDir::cleanPath(settingsPath);
s.setCustomPicsPath(base); // exactly the base directory
s.setThemesPath(base + "/pics/../decks"); // needs cleanPath normalization
const QStringList offenders = s.pathsInsideDir(base);
ASSERT_EQ(offenders.size(), 2);
ASSERT_TRUE(offenders.contains(base));
ASSERT_TRUE(offenders.contains(base + "/decks"));
}
} // namespace
int main(int argc, char **argv)