From 5c7ac6412edc6fa5ff68d92f16df20054bf9e0be Mon Sep 17 00:00:00 2001 From: AI-scor <354880559+AI-scor@users.noreply.github.com> Date: Tue, 10 Nov 2026 18:52:09 +0100 Subject: [PATCH] [Docs] Document what ReleaseChannel::getTargetVersionForCurrentOS returns (#7882) --- cockatrice/src/client/network/update/client/release_channel.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cockatrice/src/client/network/update/client/release_channel.h b/cockatrice/src/client/network/update/client/release_channel.h index 183a766ab..8506218b8 100644 --- a/cockatrice/src/client/network/update/client/release_channel.h +++ b/cockatrice/src/client/network/update/client/release_channel.h @@ -98,6 +98,10 @@ protected: Release *lastRelease; protected: + // Major OS version an installer asset targets, parsed from its file name; std::nullopt when + // the asset has to be skipped: the name carries no target version, that version is newer + // than this host's OS, or the platform publishes no updater assets (Linux, 32-bit Windows). + // nullopt therefore means "not for this host", not "unknown version". static std::optional getTargetVersionForCurrentOS(const QString &fileName); static QString findBestDownloadUrl(const QVariantList &assets); [[nodiscard]] virtual QString getReleaseChannelUrl() const = 0;