jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-11-07 10:33:24 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[Client] Settings: enlarge the settings dialog (#7483)

Browse source 
* [Client] Settings: enlarge the settings dialog

Keep settings modal per review: size to ~90% of the main window
(5% margins each side) with screen fallback, size grip and
750x700 minimum bounded to the screen. Drops the tab approach
while giving dense pages room without the tab-switch friction.

* [Client] Settings: clamp dialog width to 1280 per review

* [Client] Settings: extract dialog size calculation per review

Move the host/screen target math out of the DlgSettings constructor into a calculateDialogSize helper. Drop the leftover 'per review' wording from the clamp comment. No behavior change.

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2026-10-18 22:48:50 +02:00 • committed by GitHub
parent 679762c624
commit 665f7267e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 46 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cockatrice/src/interface/widgets/dialogs/settings_view.h
View file

@ -1,6 +1,6 @@
/**
* @file settings_view.h
* @brief Settings content widget hosted by the settings dialog (and, later, the settings tab)
* @brief Settings content widget hosted by the settings dialog
* @ingroup Dialogs
*/
#ifndef SETTINGS_VIEW_H
@ -28,7 +28,7 @@ class SettingsSearchDelegate;
* @brief Settings pages with tabbed navigation and search, without any dialog chrome
*
* Owns the search bar, the tab bar, the stacked settings pages and the search
* results view. Dialog/tab hosts only add their own frame (buttons, titles).
* results view. The settings dialog only adds its own frame (buttons, titles).
*/
class SettingsView : public QWidget
{