From 6ead408d4859e40740bad0dde1009ec303479b3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Mon, 17 Aug 2026 03:41:46 +0200 Subject: [PATCH] [UserList] Replace early return with if-else in updateSectionDivider RickyRister nit: the code is easier to follow with a standard if-else branch instead of an early return for the Buddy section. Took 1 minute --- .../src/interface/widgets/server/user/user_list_widget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cockatrice/src/interface/widgets/server/user/user_list_widget.cpp b/cockatrice/src/interface/widgets/server/user/user_list_widget.cpp index 6dfade89a..fabbf948e 100644 --- a/cockatrice/src/interface/widgets/server/user/user_list_widget.cpp +++ b/cockatrice/src/interface/widgets/server/user/user_list_widget.cpp @@ -1656,9 +1656,9 @@ void UserListWidget::updateSectionDivider(Section section) // mirroring the "Buddies online: %1 / %2" title of the non-sectioned // buddy list. divider->setText(0, tr("%1 %2 (%3/%4)").arg(arrow, sectionTitle(section)).arg(online).arg(visible)); - return; + } else { + divider->setText(0, tr("%1 %2 (%3)").arg(arrow, sectionTitle(section)).arg(visible)); } - divider->setText(0, tr("%1 %2 (%3)").arg(arrow, sectionTitle(section)).arg(visible)); } void UserListWidget::handleSectionExpansion(QTreeWidgetItem *item, bool expanded)