jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-27 08:24:39 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ReleaseChannel: don't offer 64-bit assets on 32-bit Windows

Browse source 
The old downloadMatchesCurrentOS() had an explicit 32-bit branch that
only accepted "32bit" assets. Restore that guard: 32-bit Windows builds
return no match instead of being offered the 64-bit Win10 installer that
won't run.
This commit is contained in:
Lukas Brübach 2026-09-21 11:30:07 +02:00
parent fd8ed26555
commit 709d145422
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cockatrice/src/client/network/update/client/release_channel.cpp
View file

@ -68,6 +68,12 @@ void ReleaseChannel::checkForUpdates()
// Find assets compatible with host platform (Linux is not supported by in-client updater) // Find assets compatible with host platform (Linux is not supported by in-client updater)
std::optional<int> ReleaseChannel::getTargetVersionForCurrentOS(const QString &fileName) std::optional<int> ReleaseChannel::getTargetVersionForCurrentOS(const QString &fileName)
{ {
#if defined(Q_OS_WIN) && Q_PROCESSOR_WORDSIZE == 4
// The published Windows assets are 64-bit only
Q_UNUSED(fileName);
return std::nullopt;
#endif
const QRegularExpression *regex = nullptr; const QRegularExpression *regex = nullptr;
static const std::optional<int> systemVersion = getProductVersionMajor(); static const std::optional<int> systemVersion = getProductVersionMajor();