Refactor: clean up CardDatabase pt2 (#6042)

* findPrintingWithId

* remove a param

* cleanup up usage of getCardInfo
This commit is contained in:
RickyRister 2025-07-16 03:33:38 -07:00 committed by GitHub
parent 95190c321c
commit 70b4843bc4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 39 additions and 39 deletions

View file

@ -15,7 +15,7 @@ EdhrecCommanderResponseCommanderDetailsDisplayWidget::EdhrecCommanderResponseCom
setLayout(layout);
commanderPicture = new CardInfoPictureWidget(this);
commanderPicture->setCard(CardDatabaseManager::getInstance()->getCardInfo(commanderDetails.getName()));
commanderPicture->setCard(CardDatabaseManager::getInstance()->getCard({commanderDetails.getName()}));
QWidget *currentParent = parentWidget();
TabEdhRecMain *parentTab = nullptr;

View file

@ -11,7 +11,7 @@
#include <QVBoxLayout>
#include <utility>
CardInfoFrameWidget::CardInfoFrameWidget(const QString &cardName, QWidget *parent)
CardInfoFrameWidget::CardInfoFrameWidget(QWidget *parent)
: QTabWidget(parent), info(nullptr), viewTransformationButton(nullptr), cardTextOnly(false)
{
setContentsMargins(3, 3, 3, 3);
@ -60,9 +60,6 @@ CardInfoFrameWidget::CardInfoFrameWidget(const QString &cardName, QWidget *paren
tab3->setLayout(tab3Layout);
setViewMode(SettingsCache::instance().getCardInfoViewMode());
// TODO: Change this to be by UUID
setCard(CardDatabaseManager::getInstance()->getCardInfo(cardName));
}
void CardInfoFrameWidget::retranslateUi()

View file

@ -37,7 +37,7 @@ public:
ImageAndTextView
};
explicit CardInfoFrameWidget(const QString &cardName = QString(), QWidget *parent = nullptr);
explicit CardInfoFrameWidget(QWidget *parent = nullptr);
CardInfoPtr getInfo()
{
return info;