jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-11 08:34:52 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Mark more functions as [[nodiscard]] (#6320)

Browse source 
* Fix local variable double declaration.

Took 44 seconds

* Mark functions as [[nodiscard]]

Took 31 minutes

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2025-11-16 01:39:24 +01:00 • committed by GitHub
parent 27708d5964
commit 73763b5ee6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
65 changed files with 258 additions and 257 deletions
Download patch file Download diff file Expand all files Collapse all files

18
cockatrice/src/interface/widgets/tabs/api/edhrec/api_response/card_prices/edhrec_api_response_card_prices.h
View file

@ -20,39 +20,39 @@ public:
void debugPrint() const;
// Getter methods for card prices
const QJsonObject &getCardhoarder() const
[[nodiscard]] const QJsonObject &getCardhoarder() const
{
return cardhoarder;
}
const QJsonObject &getCardkingdom() const
[[nodiscard]] const QJsonObject &getCardkingdom() const
{
return cardkingdom;
}
const QJsonObject &getCardmarket() const
[[nodiscard]] const QJsonObject &getCardmarket() const
{
return cardmarket;
}
const QJsonObject &getFace2face() const
[[nodiscard]] const QJsonObject &getFace2face() const
{
return face2face;
}
const QJsonObject &getManapool() const
[[nodiscard]] const QJsonObject &getManapool() const
{
return manapool;
}
const QJsonObject &getMtgstocks() const
[[nodiscard]] const QJsonObject &getMtgstocks() const
{
return mtgstocks;
}
const QJsonObject &getScg() const
[[nodiscard]] const QJsonObject &getScg() const
{
return scg;
}
const QJsonObject &getTcgl() const
[[nodiscard]] const QJsonObject &getTcgl() const
{
return tcgl;
}
const QJsonObject &getTcgplayer() const
[[nodiscard]] const QJsonObject &getTcgplayer() const
{
return tcgplayer;
}

2
cockatrice/src/interface/widgets/tabs/api/edhrec/tab_edhrec.h
View file

@ -20,7 +20,7 @@ public:
explicit TabEdhRec(TabSupervisor *_tabSupervisor);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
auto cardName = cardToQuery.isNull() ? QString() : cardToQuery->getName();
return tr("EDHREC: ") + cardName;

8
cockatrice/src/interface/widgets/tabs/tab_admin.h
View file

@ -29,8 +29,8 @@ private:
public:
explicit ShutdownDialog(QWidget *parent = nullptr);
QString getReason() const;
int getMinutes() const;
[[nodiscard]] QString getReason() const;
[[nodiscard]] int getMinutes() const;
};
class TabAdmin : public Tab
@ -62,11 +62,11 @@ private slots:
public:
TabAdmin(TabSupervisor *_tabSupervisor, AbstractClient *_client, bool _fullAdmin);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Administration");
}
bool getLocked() const
[[nodiscard]] bool getLocked() const
{
return locked;
}

2
cockatrice/src/interface/widgets/tabs/tab_deck_editor.h
View file

@ -86,7 +86,7 @@ public:
void retranslateUi() override;
/** @brief Returns the tab text, including modified mark if applicable. */
QString getTabText() const override;
[[nodiscard]] QString getTabText() const override;
/** @brief Creates menus for deck editing and view options. */
void createMenus() override;

4
cockatrice/src/interface/widgets/tabs/tab_game.h
View file

@ -183,9 +183,9 @@ public:
void updatePlayerListDockTitle();
bool closeRequest() override;
QString getTabText() const override;
[[nodiscard]] QString getTabText() const override;
AbstractGame *getGame() const
[[nodiscard]] AbstractGame *getGame() const
{
return game;
}

2
cockatrice/src/interface/widgets/tabs/tab_logs.h
View file

@ -62,7 +62,7 @@ public:
TabLog(TabSupervisor *_tabSupervisor, AbstractClient *_client);
~TabLog() override;
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Logs");
}

2
cockatrice/src/interface/widgets/tabs/tab_replays.h
View file

@ -84,7 +84,7 @@ signals:
public:
TabReplays(TabSupervisor *_tabSupervisor, AbstractClient *_client, const ServerInfo_User *currentUserInfo);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Game Replays");
}

12
cockatrice/src/interface/widgets/tabs/tab_room.h
View file

@ -68,7 +68,7 @@ private:
QAction *aLeaveRoom;
QAction *aOpenChatSettings;
QAction *aClearChat;
QString sanitizeHtml(QString dirty) const;
[[nodiscard]] QString sanitizeHtml(QString dirty) const;
QStringList autocompleteUserList;
QCompleter *completer;
@ -106,23 +106,23 @@ public:
void retranslateUi() override;
void tabActivated() override;
void processRoomEvent(const RoomEvent &event);
int getRoomId() const
[[nodiscard]] int getRoomId() const
{
return roomId;
}
const QMap<int, QString> &getGameTypes() const
[[nodiscard]] const QMap<int, QString> &getGameTypes() const
{
return gameTypes;
}
QString getChannelName() const
[[nodiscard]] QString getChannelName() const
{
return roomName;
}
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return roomName;
}
const ServerInfo_User *getUserInfo() const
[[nodiscard]] const ServerInfo_User *getUserInfo() const
{
return ownUser;
}

2
cockatrice/src/interface/widgets/tabs/tab_server.h
View file

@ -63,7 +63,7 @@ private:
public:
TabServer(TabSupervisor *_tabSupervisor, AbstractClient *_client);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Server");
}

22
cockatrice/src/interface/widgets/tabs/tab_supervisor.h
View file

@ -64,8 +64,8 @@ class CloseButton : public QAbstractButton
Q_OBJECT
public:
explicit CloseButton(QWidget *parent = nullptr);
QSize sizeHint() const override;
inline QSize minimumSizeHint() const override
[[nodiscard]] QSize sizeHint() const override;
[[nodiscard]] QSize minimumSizeHint() const override
{
return sizeHint();
}
@ -129,36 +129,36 @@ public:
void start(const ServerInfo_User &userInfo);
void startLocal(const QList<AbstractClient *> &_clients);
void stop();
bool getIsLocalGame() const
[[nodiscard]] bool getIsLocalGame() const
{
return isLocalGame;
}
int getGameCount() const
[[nodiscard]] int getGameCount() const
{
return gameTabs.size();
}
TabAccount *getTabAccount() const
[[nodiscard]] TabAccount *getTabAccount() const
{
return tabAccount;
}
ServerInfo_User *getUserInfo() const
[[nodiscard]] ServerInfo_User *getUserInfo() const
{
return userInfo;
}
AbstractClient *getClient() const;
const UserListManager *getUserListManager() const
[[nodiscard]] AbstractClient *getClient() const;
[[nodiscard]] const UserListManager *getUserListManager() const
{
return userListManager;
}
const QMap<int, TabRoom *> &getRoomTabs() const
[[nodiscard]] const QMap<int, TabRoom *> &getRoomTabs() const
{
return roomTabs;
}
QList<AbstractTabDeckEditor *> getDeckEditorTabs() const
[[nodiscard]] QList<AbstractTabDeckEditor *> getDeckEditorTabs() const
{
return deckEditorTabs;
}
bool getAdminLocked() const;
[[nodiscard]] bool getAdminLocked() const;
void closeEvent(QCloseEvent *event) override;
bool switchToGameTabIfAlreadyExists(const int gameId);
static void actShowPopup(const QString &message);

2
cockatrice/src/interface/widgets/tabs/tab_visual_database_display.h
View file

@ -23,7 +23,7 @@ private:
public:
TabVisualDatabaseDisplay(TabSupervisor *_tabSupervisor);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Visual Database Display");
}

2
cockatrice/src/interface/widgets/tabs/visual_deck_editor/tab_deck_editor_visual.h
View file

@ -125,7 +125,7 @@ public:
* @brief Get the display text for the tab.
* @return Tab text with optional modification indicator.
*/
QString getTabText() const override;
[[nodiscard]] QString getTabText() const override;
/**
* @brief Update the currently selected card in the deck and UI.

4
cockatrice/src/interface/widgets/tabs/visual_deck_editor/tab_deck_editor_visual_tab_widget.h
View file

@ -73,10 +73,10 @@ public:
void setTabTitle(int index, const QString &title);
/// Get the currently active tab widget.
QWidget *getCurrentTab() const;
[[nodiscard]] QWidget *getCurrentTab() const;
/// Get the total number of tabs.
int getTabCount() const;
[[nodiscard]] int getTabCount() const;
VisualDeckEditorWidget *visualDeckView; ///< Visual deck editor widget.
DeckAnalyticsWidget *deckAnalytics; ///< Deck analytics widget.