diff --git a/dbconverter/CMakeLists.txt b/dbconverter/CMakeLists.txt index acf60bf03..b2de9dcb8 100644 --- a/dbconverter/CMakeLists.txt +++ b/dbconverter/CMakeLists.txt @@ -25,6 +25,7 @@ add_executable(dbconverter MACOSX_BUNDLE ${dbconverter_SOURCES}) target_link_libraries( dbconverter PRIVATE libcockatrice_card + PRIVATE libcockatrice_interfaces PRIVATE libcockatrice_settings PRIVATE ${DB_CONVERTER_QT_MODULES} ) diff --git a/dbconverter/src/main.cpp b/dbconverter/src/main.cpp index f64392fa8..67748fa45 100644 --- a/dbconverter/src/main.cpp +++ b/dbconverter/src/main.cpp @@ -54,7 +54,6 @@ int main(int argc, char *argv[]) exit(0); } - settingsCache = new SettingsCache; CardDatabaseConverter *db = new CardDatabaseConverter; qInfo() << "---------------------------------------------"; diff --git a/dbconverter/src/main.h b/dbconverter/src/main.h index 079f3ebf7..61ddcaaa8 100644 --- a/dbconverter/src/main.h +++ b/dbconverter/src/main.h @@ -2,8 +2,8 @@ #define MAIN_H #include -#include #include +#include class CardDatabaseConverter : public CardDatabase { diff --git a/dbconverter/src/mocks.cpp b/dbconverter/src/mocks.cpp index 6aa108e57..c54d2b9c2 100644 --- a/dbconverter/src/mocks.cpp +++ b/dbconverter/src/mocks.cpp @@ -46,12 +46,7 @@ QString SettingsCache::getSafeConfigFilePath(QString /* configEntry */, QString { return defaultPath; } -SettingsCache::SettingsCache() - : settings{new QSettings("global.ini", QSettings::IniFormat, this)}, shortcutsSettings{nullptr}, - cardDatabaseSettings{new CardDatabaseSettings("", this)}, serversSettings{nullptr}, messageSettings{nullptr}, - gameFiltersSettings{nullptr}, layoutsSettings{nullptr}, downloadSettings{nullptr} -{ -} + void SettingsCache::setUseTearOffMenus(bool /* _useTearOffMenus */) { } @@ -450,11 +445,4 @@ void SettingsCache::setRoundCardCorners(bool /* _roundCardCorners */) void CardPictureLoader::clearPixmapCache(CardInfoPtr /* card */) { -} - -SettingsCache *settingsCache; - -SettingsCache &SettingsCache::instance() -{ - return *settingsCache; -} +} \ No newline at end of file diff --git a/dbconverter/src/mocks.h b/dbconverter/src/mocks.h index 1e49ab32e..929092bd7 100644 --- a/dbconverter/src/mocks.h +++ b/dbconverter/src/mocks.h @@ -10,7 +10,8 @@ #define PICTURELOADER_H -#include <../../cockatrice/src/client/settings/cache_settings.h> +#include "../../cockatrice/src/client/settings/cache_settings.h" + #include #include diff --git a/tests/carddatabase/carddatabase_test.cpp b/tests/carddatabase/carddatabase_test.cpp index f3de287e5..35c4eb654 100644 --- a/tests/carddatabase/carddatabase_test.cpp +++ b/tests/carddatabase/carddatabase_test.cpp @@ -7,7 +7,6 @@ namespace TEST(CardDatabaseTest, LoadXml) { - settingsCache = new SettingsCache; CardDatabase *db = new CardDatabase; // ensure the card database is empty at start diff --git a/tests/carddatabase/filter_string_test.cpp b/tests/carddatabase/filter_string_test.cpp index 46a110b3a..a96fbe395 100644 --- a/tests/carddatabase/filter_string_test.cpp +++ b/tests/carddatabase/filter_string_test.cpp @@ -3,6 +3,7 @@ #include "gtest/gtest.h" #include +#include #define QUERY(name, card, query, match) \ TEST_F(CardQuery, name) \ @@ -72,8 +73,6 @@ QUERY(Color4, cat, "c!gw", false) int main(int argc, char **argv) { - settingsCache = new SettingsCache; - ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/tests/carddatabase/mocks.cpp b/tests/carddatabase/mocks.cpp index 7d46a68c2..511ebb26d 100644 --- a/tests/carddatabase/mocks.cpp +++ b/tests/carddatabase/mocks.cpp @@ -455,10 +455,3 @@ void SettingsCache::setRoundCardCorners(bool /* _roundCardCorners */) void CardPictureLoader::clearPixmapCache(CardInfoPtr /* card */) { } - -SettingsCache *settingsCache; - -SettingsCache &SettingsCache::instance() -{ - return *settingsCache; -}