jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-15 19:47:46 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[CardDatabaseModel] Pass CardInfoPtr by const ref (#6940)

Browse source
This commit is contained in:
RickyRister 2026-05-26 18:53:20 -07:00 • committed by GitHub
parent 1d5d3f2d38
commit 7f30728f87
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libcockatrice_models/libcockatrice/models/database/card_database_model.cpp
View file

@ -81,7 +81,7 @@ QVariant CardDatabaseModel::headerData(int section, Qt::Orientation orientation,
} }
} }
void CardDatabaseModel::cardInfoChanged(CardInfoPtr card) void CardDatabaseModel::cardInfoChanged(const CardInfoPtr &card)
{ {
const int row = cardList.indexOf(card); const int row = cardList.indexOf(card);
if (row == -1) { if (row == -1) {
@ -91,7 +91,7 @@ void CardDatabaseModel::cardInfoChanged(CardInfoPtr card)
emit dataChanged(index(row, 0), index(row, CARDDBMODEL_COLUMNS - 1)); emit dataChanged(index(row, 0), index(row, CARDDBMODEL_COLUMNS - 1));
} }
bool CardDatabaseModel::checkCardHasAtLeastOneEnabledSet(CardInfoPtr card) bool CardDatabaseModel::checkCardHasAtLeastOneEnabledSet(const CardInfoPtr &card) const
{ {
if (!showOnlyCardsFromEnabledSets) { if (!showOnlyCardsFromEnabledSets) {
return true; return true;
@ -125,7 +125,7 @@ void CardDatabaseModel::cardDatabaseEnabledSetsChanged()
} }
} }
void CardDatabaseModel::cardAdded(CardInfoPtr card) void CardDatabaseModel::cardAdded(const CardInfoPtr &card)
{ {
if (checkCardHasAtLeastOneEnabledSet(card)) { if (checkCardHasAtLeastOneEnabledSet(card)) {
// add the card if it's present in at least one enabled set // add the card if it's present in at least one enabled set

6
libcockatrice_models/libcockatrice/models/database/card_database_model.h
View file

@ -51,11 +51,11 @@ private:
CardDatabase *db; CardDatabase *db;
bool showOnlyCardsFromEnabledSets; bool showOnlyCardsFromEnabledSets;
inline bool checkCardHasAtLeastOneEnabledSet(CardInfoPtr card); inline bool checkCardHasAtLeastOneEnabledSet(const CardInfoPtr &card) const;
private slots: private slots:
void cardAdded(CardInfoPtr card); void cardAdded(const CardInfoPtr &card);
void cardRemoved(CardInfoPtr card); void cardRemoved(CardInfoPtr card);
void cardInfoChanged(CardInfoPtr card); void cardInfoChanged(const CardInfoPtr &card);
void cardDatabaseEnabledSetsChanged(); void cardDatabaseEnabledSetsChanged();
}; };