From 8b3f71c46189c02db74e73a8ea4c235acaf6b807 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <Bruebach.Lukas@bdosecurity.de>
Date: Fri, 23 Oct 2026 09:54:58 +0200
Subject: [PATCH] [Tests] Define ~SettingsCache in the benchmark mock

The mock includes cache_settings.h, which declares the destructor out of line,
so the vtable emitted for the mock SettingsCache references a definition that
never exists and picture_loader_benchmark_test fails to link. Default it: the
real destructor only frees release channels, and the mock creates none.
---
 tests/picture_loader_benchmark/settings_cache_mock.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/picture_loader_benchmark/settings_cache_mock.cpp b/tests/picture_loader_benchmark/settings_cache_mock.cpp
index 13e831b62..70b08644c 100644
--- a/tests/picture_loader_benchmark/settings_cache_mock.cpp
+++ b/tests/picture_loader_benchmark/settings_cache_mock.cpp
@@ -144,6 +144,10 @@ SettingsCache::SettingsCache()
     loadPaths();
 }
 
+// The real destructor deletes the release channels; this mock never creates any,
+// but the vtable still needs the definition.
+SettingsCache::~SettingsCache() = default;
+
 void SettingsCache::loadPaths()
 {
     QString dataPath = getDataPath();