From 8cbfe85ed4a63c644d9a3f113cd1a06ea735ed18 Mon Sep 17 00:00:00 2001 From: danbopes Date: Sun, 9 Feb 2025 07:12:16 -0500 Subject: [PATCH] Fix db reconnecting issues (#5590) See: https://github.com/Cockatrice/Cockatrice/commit/c1b0d50237398e2a7f02f8e85ebb35b8b5b491e5#diff-02a32f437187bd4cbfab74877100fee0cfc669dab2c05418681a3557c2cf73f2R109 We should be checking to see if the query is notActive. In this case, we're literally closing and reopening the connection to the database every time `checkSql()` is called, which is called in numerous places. --- servatrice/src/servatrice_database_interface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/servatrice/src/servatrice_database_interface.cpp b/servatrice/src/servatrice_database_interface.cpp index feeb5c792..bff05293a 100644 --- a/servatrice/src/servatrice_database_interface.cpp +++ b/servatrice/src/servatrice_database_interface.cpp @@ -108,7 +108,7 @@ bool Servatrice_DatabaseInterface::checkSql() } auto query = QSqlQuery(sqlDatabase); - if (query.exec("select 1") && query.isActive()) { + if (query.exec("select 1") && !query.isActive()) { return openDatabase(); }