jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-09 09:33:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove unnecessary virtual methods

Browse source
This commit is contained in:
RickyRister 2025-11-30 03:09:01 -08:00
parent 87edc756c9
commit 8d088f8677
2 changed files with 1 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp
View file

@ -449,11 +449,8 @@ bool DeckList::loadFromStream_Plain(QTextStream &in, bool preserveMetadata)
cardName.replace(diff.key(), diff.value());
}
// Resolve complete card name, this function does nothing if the name is not found
cardName = getCompleteCardName(cardName);
// Determine the zone (mainboard/sideboard)
QString zoneName = getCardZoneFromName(cardName, sideboard ? DECK_ZONE_SIDE : DECK_ZONE_MAIN);
QString zoneName = sideboard ? DECK_ZONE_SIDE : DECK_ZONE_MAIN;
// make new entry in decklist
new DecklistCardNode(cardName, amount, getZoneObjFromName(zoneName), -1, setCode, collectorNumber);

23
libcockatrice_deck_list/libcockatrice/deck_list/deck_list.h
View file

@ -153,29 +153,6 @@ private:
InnerDecklistNode *getZoneObjFromName(const QString &zoneName);
public:
/**
* @brief Map a card name to its zone.
* Override in subclasses for format-specific logic.
* @param cardName Card being placed.
* @param currentZoneName Zone candidate.
* @return Zone name to use.
*/
virtual QString getCardZoneFromName(const QString /*cardName*/, QString currentZoneName)
{
return currentZoneName;
}
/**
* @brief Produce the complete display name of a card.
* Override in subclasses to add set suffixes or annotations.
* @param cardName Base name.
* @return Full display name.
*/
virtual QString getCompleteCardName(const QString &cardName) const
{
return cardName;
}
/// @name Metadata setters
///@{
void setName(const QString &_name = QString())