jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-29 09:22:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Extract evaluateCreateCounter helper to directly test reserved-name guard in cmdCreateCounter

Browse source
This commit is contained in:
DawnFire42 2026-08-10 16:27:13 -04:00
parent 1f5df5b0e1
commit 9121064709
No known key found for this signature in database
GPG key ID: 24BB855EE2911B33
3 changed files with 52 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

32
tests/command_zone_tests/counter_command_auth_test.cpp
View file

@ -150,23 +150,37 @@ TEST(EvaluateSetCounterActive, RejectsDisablingPartnerTaxWhenAccumulated)
Response::RespContextError);
}
// CounterNames::isTaxCounter (guards cmdCreateCounter against reserved names)
// evaluateCreateCounter
TEST(CounterNamesIsTaxCounter, RejectsCommanderTaxName)
TEST(EvaluateCreateCounter, RejectsWhenGameNotStarted)
{
EXPECT_TRUE(CounterNames::isTaxCounter(CounterNames::CommanderTax));
EXPECT_EQ(Server_Player::evaluateCreateCounter(/*gameStarted=*/false, /*playerConceded=*/false, "mycounter"),
Response::RespGameNotStarted);
}
TEST(CounterNamesIsTaxCounter, RejectsPartnerTaxName)
TEST(EvaluateCreateCounter, RejectsWhenPlayerConceded)
{
EXPECT_TRUE(CounterNames::isTaxCounter(CounterNames::PartnerTax));
EXPECT_EQ(Server_Player::evaluateCreateCounter(/*gameStarted=*/true, /*playerConceded=*/true, "mycounter"),
Response::RespContextError);
}
TEST(CounterNamesIsTaxCounter, AllowsOrdinaryName)
TEST(EvaluateCreateCounter, RejectsCommanderTaxName)
{
EXPECT_FALSE(CounterNames::isTaxCounter("life"));
EXPECT_FALSE(CounterNames::isTaxCounter("poison"));
EXPECT_FALSE(CounterNames::isTaxCounter(""));
EXPECT_EQ(Server_Player::evaluateCreateCounter(true, false, CounterNames::CommanderTax),
Response::RespFunctionNotAllowed);
}
TEST(EvaluateCreateCounter, RejectsPartnerTaxName)
{
EXPECT_EQ(Server_Player::evaluateCreateCounter(true, false, CounterNames::PartnerTax),
Response::RespFunctionNotAllowed);
}
TEST(EvaluateCreateCounter, AllowsOrdinaryNames)
{
EXPECT_EQ(Server_Player::evaluateCreateCounter(true, false, "life"), Response::RespOk);
EXPECT_EQ(Server_Player::evaluateCreateCounter(true, false, "poison"), Response::RespOk);
EXPECT_EQ(Server_Player::evaluateCreateCounter(true, false, ""), Response::RespOk);
}
// evaluateModifyCounter (shared by cmdIncCounter / cmdSetCounter)