jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-14 22:42:14 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pass by const ref when able

Browse source
This commit is contained in:
RickyRister 2025-04-20 21:52:10 -07:00
parent b75c88d6c7
commit 99254dad6e
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
oracle/src/oracleimporter.cpp
View file

@ -12,7 +12,7 @@
SplitCardPart::SplitCardPart(const QString &_name, SplitCardPart::SplitCardPart(const QString &_name,
const QString &_text, const QString &_text,
const QVariantHash &_properties, const QVariantHash &_properties,
const CardInfoPerSet _setInfo) const CardInfoPerSet &_setInfo)
: name(_name), text(_text), properties(_properties), setInfo(_setInfo) : name(_name), text(_text), properties(_properties), setInfo(_setInfo)
{ {
} }
@ -125,11 +125,11 @@ static void sortAndReduceColors(QString &colors)
} }
CardInfoPtr OracleImporter::addCard(QString name, CardInfoPtr OracleImporter::addCard(QString name,
QString text, const QString &text,
bool isToken, bool isToken,
QVariantHash properties, QVariantHash properties,
QList<CardRelation *> &relatedCards, const QList<CardRelation *> &relatedCards,
CardInfoPerSet setInfo) const CardInfoPerSet &setInfo)
{ {
// Workaround for card name weirdness // Workaround for card name weirdness
name = name.replace("Æ", "AE"); name = name.replace("Æ", "AE");

9
oracle/src/oracleimporter.h
View file

@ -92,7 +92,8 @@ public:
class SplitCardPart class SplitCardPart
{ {
public: public:
SplitCardPart(const QString &_name, const QString &_text, const QVariantHash &_properties, CardInfoPerSet setInfo); SplitCardPart(const QString &_name, const QString &_text, const QVariantHash &_properties,
const CardInfoPerSet &setInfo);
inline const QString &getName() const inline const QString &getName() const
{ {
return name; return name;
@ -136,11 +137,11 @@ private:
QList<SetToDownload> allSets; QList<SetToDownload> allSets;
CardInfoPtr addCard(QString name, CardInfoPtr addCard(QString name,
QString text, const QString &text,
bool isToken, bool isToken,
QVariantHash properties, QVariantHash properties,
QList<CardRelation *> &relatedCards, const QList<CardRelation *> &relatedCards,
CardInfoPerSet setInfo); const CardInfoPerSet &setInfo);
signals: signals:
void setIndexChanged(int cardsImported, int setIndex, const QString &setName); void setIndexChanged(int cardsImported, int setIndex, const QString &setName);
void dataReadProgress(int bytesRead, int totalBytes); void dataReadProgress(int bytesRead, int totalBytes);