From 9bc6ae1567b0e32aeae7299e1e072b4ae496c213 Mon Sep 17 00:00:00 2001
From: RickyRister <42636155+RickyRister@users.noreply.github.com>
Date: Sun, 23 Mar 2025 09:03:56 -0700
Subject: [PATCH] Fix delete action in filters not working (#5765)

* Fix delete action in filters not working

* move filterRemove under slots
---
 .../ui/widgets/deck_editor/deck_editor_filter_dock_widget.cpp | 4 ++--
 .../ui/widgets/deck_editor/deck_editor_filter_dock_widget.h   | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.cpp b/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.cpp
index 2f03ad656..c60b1733b 100644
--- a/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.cpp
+++ b/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.cpp
@@ -96,11 +96,11 @@ void DeckEditorFilterDockWidget::filterViewCustomContextMenu(const QPoint &point
 
     action = menu.addAction(QString("delete"));
     action->setData(point);
-    connect(&menu, SIGNAL(triggered(QAction *)), this, SLOT(filterRemove(QAction *)));
+    connect(&menu, &QMenu::triggered, this, &DeckEditorFilterDockWidget::filterRemove);
     menu.exec(filterView->mapToGlobal(point));
 }
 
-void DeckEditorFilterDockWidget::filterRemove(QAction *action)
+void DeckEditorFilterDockWidget::filterRemove(const QAction *action)
 {
     QPoint point;
     QModelIndex idx;
diff --git a/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.h b/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.h
index 3113b2e24..9cd8d8d6f 100644
--- a/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.h
+++ b/cockatrice/src/client/ui/widgets/deck_editor/deck_editor_filter_dock_widget.h
@@ -28,10 +28,9 @@ private:
     KeySignals filterViewKeySignals;
     QWidget *filterBox;
 
-    void filterRemove(QAction *action);
-
 private slots:
     void filterViewCustomContextMenu(const QPoint &point);
+    void filterRemove(const QAction *action);
     void actClearFilterAll();
     void actClearFilterOne();
     void refreshShortcuts();