jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-21 09:05:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Simplify const

Browse source
This commit is contained in:
Lukas Brübach 2026-09-07 21:22:05 +02:00
parent 331fb24125
commit 9d7ce3fcaa
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
oracle/src/oracleimporter.cpp
View file

@ -101,12 +101,8 @@ bool OracleImporter::readSetsFromByteArray(QByteArray data)
* types (e.g. "Artifact Creature") or multiple faces (e.g. split/adventure cards).
* A lower index means a higher priority.
*/
static const QStringList &mainCardTypePriority()
{
static const QStringList priority = {"Planeswalker", "Creature", "Land", "Sorcery",
"Instant", "Artifact", "Enchantment"};
return priority;
}
static const QStringList MAIN_CARD_TYPE_PRIORITY = {"Planeswalker", "Creature", "Land", "Sorcery",
"Instant", "Artifact", "Enchantment"};
/**
* Returns the priority (index) of the given main card type. Known types map to their
@ -114,7 +110,7 @@ static const QStringList &mainCardTypePriority()
*/
static int mainCardTypePriority(const QString &mainCardType)
{
return mainCardTypePriority().indexOf(mainCardType);
return MAIN_CARD_TYPE_PRIORITY.indexOf(mainCardType);
}
static QString getMainCardType(const QStringList &typeList)
@ -123,7 +119,7 @@ static QString getMainCardType(const QStringList &typeList)
return {};
}
for (const auto &type : mainCardTypePriority()) {
for (const auto &type : MAIN_CARD_TYPE_PRIORITY) {
if (typeList.contains(type)) {
return type;
}