jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-12 00:54:53 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[Fix-Warnings] Mark const getters as [[nodiscard]] (#6365)

Browse source 
Took 45 minutes

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2025-11-28 21:38:54 +01:00 • committed by GitHub
parent a1a3b02d3a
commit 9ece4bfd9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
58 changed files with 548 additions and 543 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cockatrice/src/interface/widgets/deck_editor/deck_editor_deck_dock_widget.h
View file

@ -104,7 +104,7 @@ private:
QAction *aRemoveCard, *aIncrement, *aDecrement, *aSwapCard;
void recursiveExpand(const QModelIndex &index);
QModelIndexList getSelectedCardNodes() const;
[[nodiscard]] QModelIndexList getSelectedCardNodes() const;
private slots:
void decklistCustomMenu(QPoint point);

2
cockatrice/src/interface/widgets/dialogs/dlg_convert_deck_to_cod_format.h
View file

@ -22,7 +22,7 @@ public:
explicit DialogConvertDeckToCodFormat(QWidget *parent);
void retranslateUi();
bool dontAskAgain() const;
[[nodiscard]] bool dontAskAgain() const;
private:
QVBoxLayout *layout;

4
cockatrice/src/interface/widgets/dialogs/dlg_edit_password.h
View file

@ -20,11 +20,11 @@ class DlgEditPassword : public QDialog
Q_OBJECT
public:
explicit DlgEditPassword(QWidget *parent = nullptr);
QString getOldPassword() const
[[nodiscard]] QString getOldPassword() const
{
return oldPasswordEdit->text();
}
QString getNewPassword() const
[[nodiscard]] QString getNewPassword() const
{
return newPasswordEdit->text();
}

34
cockatrice/src/interface/widgets/dialogs/dlg_filter_games.h
View file

@ -58,32 +58,32 @@ public:
const GamesProxyModel *_gamesProxyModel,
QWidget *parent = nullptr);
bool getHideFullGames() const;
bool getHideGamesThatStarted() const;
bool getHidePasswordProtectedGames() const;
[[nodiscard]] bool getHideFullGames() const;
[[nodiscard]] bool getHideGamesThatStarted() const;
[[nodiscard]] bool getHidePasswordProtectedGames() const;
void setShowPasswordProtectedGames(bool _passwordProtectedGamesHidden);
bool getHideBuddiesOnlyGames() const;
[[nodiscard]] bool getHideBuddiesOnlyGames() const;
void setHideBuddiesOnlyGames(bool _hideBuddiesOnlyGames);
bool getHideOpenDecklistGames() const;
[[nodiscard]] bool getHideOpenDecklistGames() const;
void setHideOpenDecklistGames(bool _hideOpenDecklistGames);
bool getHideIgnoredUserGames() const;
[[nodiscard]] bool getHideIgnoredUserGames() const;
void setHideIgnoredUserGames(bool _hideIgnoredUserGames);
bool getHideNotBuddyCreatedGames() const;
QString getGameNameFilter() const;
[[nodiscard]] bool getHideNotBuddyCreatedGames() const;
[[nodiscard]] QString getGameNameFilter() const;
void setGameNameFilter(const QString &_gameNameFilter);
QStringList getCreatorNameFilters() const;
[[nodiscard]] QStringList getCreatorNameFilters() const;
void setCreatorNameFilter(const QString &_creatorNameFilter);
QSet<int> getGameTypeFilter() const;
[[nodiscard]] QSet<int> getGameTypeFilter() const;
void setGameTypeFilter(const QSet<int> &_gameTypeFilter);
int getMaxPlayersFilterMin() const;
int getMaxPlayersFilterMax() const;
[[nodiscard]] int getMaxPlayersFilterMin() const;
[[nodiscard]] int getMaxPlayersFilterMax() const;
void setMaxPlayersFilter(int _maxPlayersFilterMin, int _maxPlayersFilterMax);
QTime getMaxGameAge() const;
[[nodiscard]] QTime getMaxGameAge() const;
const QMap<QTime, QString> gameAgeMap;
bool getShowOnlyIfSpectatorsCanWatch() const;
bool getShowSpectatorPasswordProtected() const;
bool getShowOnlyIfSpectatorsCanChat() const;
bool getShowOnlyIfSpectatorsCanSeeHands() const;
[[nodiscard]] bool getShowOnlyIfSpectatorsCanWatch() const;
[[nodiscard]] bool getShowSpectatorPasswordProtected() const;
[[nodiscard]] bool getShowOnlyIfSpectatorsCanChat() const;
[[nodiscard]] bool getShowOnlyIfSpectatorsCanSeeHands() const;
};
#endif

6
cockatrice/src/interface/widgets/dialogs/dlg_forgot_password_request.h
View file

@ -20,15 +20,15 @@ class DlgForgotPasswordRequest : public QDialog
Q_OBJECT
public:
explicit DlgForgotPasswordRequest(QWidget *parent = nullptr);
QString getHost() const
[[nodiscard]] QString getHost() const
{
return hostEdit->text();
}
int getPort() const
[[nodiscard]] int getPort() const
{
return portEdit->text().toInt();
}
QString getPlayerName() const
[[nodiscard]] QString getPlayerName() const
{
return playernameEdit->text();
}

10
cockatrice/src/interface/widgets/dialogs/dlg_forgot_password_reset.h
View file

@ -20,23 +20,23 @@ class DlgForgotPasswordReset : public QDialog
Q_OBJECT
public:
explicit DlgForgotPasswordReset(QWidget *parent = nullptr);
QString getHost() const
[[nodiscard]] QString getHost() const
{
return hostEdit->text();
}
int getPort() const
[[nodiscard]] int getPort() const
{
return portEdit->text().toInt();
}
QString getPlayerName() const
[[nodiscard]] QString getPlayerName() const
{
return playernameEdit->text();
}
QString getToken() const
[[nodiscard]] QString getToken() const
{
return tokenEdit->text();
}
QString getPassword() const
[[nodiscard]] QString getPassword() const
{
return newpasswordEdit->text();
}

14
cockatrice/src/interface/widgets/dialogs/dlg_register.h
View file

@ -20,31 +20,31 @@ class DlgRegister : public QDialog
Q_OBJECT
public:
explicit DlgRegister(QWidget *parent = nullptr);
QString getHost() const
[[nodiscard]] QString getHost() const
{
return hostEdit->text();
}
int getPort() const
[[nodiscard]] int getPort() const
{
return portEdit->text().toInt();
}
QString getPlayerName() const
[[nodiscard]] QString getPlayerName() const
{
return playernameEdit->text();
}
QString getPassword() const
[[nodiscard]] QString getPassword() const
{
return passwordEdit->text();
}
QString getEmail() const
[[nodiscard]] QString getEmail() const
{
return emailEdit->text();
}
QString getCountry() const
[[nodiscard]] QString getCountry() const
{
return countryEdit->currentIndex() == 0 ? "" : countryEdit->currentText();
}
QString getRealName() const
[[nodiscard]] QString getRealName() const
{
return realnameEdit->text();
}

12
cockatrice/src/interface/widgets/dialogs/tip_of_the_day.h
View file

@ -14,19 +14,19 @@ class TipOfTheDay
{
public:
explicit TipOfTheDay(QString _title, QString _content, QString _imagePath, QDate _date);
QString getTitle() const
[[nodiscard]] QString getTitle() const
{
return title;
}
QString getContent() const
[[nodiscard]] QString getContent() const
{
return content;
}
QString getImagePath() const
[[nodiscard]] QString getImagePath() const
{
return imagePath;
}
QDate getDate() const
[[nodiscard]] QDate getDate() const
{
return date;
}
@ -51,8 +51,8 @@ public:
explicit TipsOfTheDay(QString xmlPath, QObject *parent = nullptr);
~TipsOfTheDay() override;
TipOfTheDay getTip(int tipId);
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
QVariant data(const QModelIndex &index, int role) const override;
[[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override;
[[nodiscard]] QVariant data(const QModelIndex &index, int role) const override;
private:
QList<TipOfTheDay> *tipList;

6
cockatrice/src/interface/widgets/replay/replay_timeline_widget.h
View file

@ -60,10 +60,10 @@ public:
explicit ReplayTimelineWidget(QWidget *parent = nullptr);
void setTimeline(const QList<int> &_replayTimeline);
QSize sizeHint() const override;
QSize minimumSizeHint() const override;
[[nodiscard]] QSize sizeHint() const override;
[[nodiscard]] QSize minimumSizeHint() const override;
void setTimeScaleFactor(qreal _timeScaleFactor);
int getCurrentEvent() const
[[nodiscard]] int getCurrentEvent() const
{
return currentEvent;
}

51
cockatrice/src/interface/widgets/server/games_model.h
View file

@ -42,19 +42,20 @@ public:
*/
GamesModel(const QMap<int, QString> &_rooms, const QMap<int, GameTypeMap> &_gameTypes, QObject *parent = nullptr);
int rowCount(const QModelIndex &parent = QModelIndex()) const override
[[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override
{
return parent.isValid() ? 0 : gameList.size();
}
int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override
[[nodiscard]] int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override
{
return NUM_COLS;
}
QVariant data(const QModelIndex &index, int role) const override;
[[nodiscard]] QVariant data(const QModelIndex &index, int role) const override;
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
[[nodiscard]] QVariant
headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
/**
* @brief Formats the game creation time into a human-readable string.
@ -148,71 +149,71 @@ public:
explicit GamesProxyModel(QObject *parent = nullptr, const UserListProxy *_userListProxy = nullptr);
// Getters for filter parameters
bool getHideBuddiesOnlyGames() const
[[nodiscard]] bool getHideBuddiesOnlyGames() const
{
return hideBuddiesOnlyGames;
}
bool getHideIgnoredUserGames() const
[[nodiscard]] bool getHideIgnoredUserGames() const
{
return hideIgnoredUserGames;
}
bool getHideFullGames() const
[[nodiscard]] bool getHideFullGames() const
{
return hideFullGames;
}
bool getHideGamesThatStarted() const
[[nodiscard]] bool getHideGamesThatStarted() const
{
return hideGamesThatStarted;
}
bool getHidePasswordProtectedGames() const
[[nodiscard]] bool getHidePasswordProtectedGames() const
{
return hidePasswordProtectedGames;
}
bool getHideNotBuddyCreatedGames() const
[[nodiscard]] bool getHideNotBuddyCreatedGames() const
{
return hideNotBuddyCreatedGames;
}
bool getHideOpenDecklistGames() const
[[nodiscard]] bool getHideOpenDecklistGames() const
{
return hideOpenDecklistGames;
}
QString getGameNameFilter() const
[[nodiscard]] QString getGameNameFilter() const
{
return gameNameFilter;
}
QStringList getCreatorNameFilters() const
[[nodiscard]] QStringList getCreatorNameFilters() const
{
return creatorNameFilters;
}
QSet<int> getGameTypeFilter() const
[[nodiscard]] QSet<int> getGameTypeFilter() const
{
return gameTypeFilter;
}
int getMaxPlayersFilterMin() const
[[nodiscard]] int getMaxPlayersFilterMin() const
{
return maxPlayersFilterMin;
}
int getMaxPlayersFilterMax() const
[[nodiscard]] int getMaxPlayersFilterMax() const
{
return maxPlayersFilterMax;
}
const QTime &getMaxGameAge() const
[[nodiscard]] const QTime &getMaxGameAge() const
{
return maxGameAge;
}
bool getShowOnlyIfSpectatorsCanWatch() const
[[nodiscard]] bool getShowOnlyIfSpectatorsCanWatch() const
{
return showOnlyIfSpectatorsCanWatch;
}
bool getShowSpectatorPasswordProtected() const
[[nodiscard]] bool getShowSpectatorPasswordProtected() const
{
return showSpectatorPasswordProtected;
}
bool getShowOnlyIfSpectatorsCanChat() const
[[nodiscard]] bool getShowOnlyIfSpectatorsCanChat() const
{
return showOnlyIfSpectatorsCanChat;
}
bool getShowOnlyIfSpectatorsCanSeeHands() const
[[nodiscard]] bool getShowOnlyIfSpectatorsCanSeeHands() const
{
return showOnlyIfSpectatorsCanSeeHands;
}
@ -328,7 +329,7 @@ public:
/**
* @brief Returns the number of games filtered out by the current filter.
*/
int getNumFilteredGames() const;
[[nodiscard]] int getNumFilteredGames() const;
/**
* @brief Resets all filter parameters to default values.
@ -338,7 +339,7 @@ public:
/**
* @brief Returns true if all filter parameters are set to their defaults.
*/
bool areFilterParametersSetToDefaults() const;
[[nodiscard]] bool areFilterParametersSetToDefaults() const;
/**
* @brief Loads filter parameters from persistent settings.
@ -358,8 +359,8 @@ public:
void refresh();
protected:
bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
bool filterAcceptsRow(int sourceRow) const;
[[nodiscard]] bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
[[nodiscard]] bool filterAcceptsRow(int sourceRow) const;
};
#endif

41
cockatrice/src/interface/widgets/server/remote/remote_decklist_tree_widget.h
View file

@ -34,11 +34,11 @@ public:
{
}
virtual ~Node() = default;
DirectoryNode *getParent() const
[[nodiscard]] DirectoryNode *getParent() const
{
return parent;
}
QString getName() const
[[nodiscard]] QString getName() const
{
return name;
}
@ -49,9 +49,9 @@ public:
explicit DirectoryNode(const QString &_name = QString(), DirectoryNode *_parent = nullptr);
~DirectoryNode() override;
void clearTree();
QString getPath() const;
[[nodiscard]] QString getPath() const;
DirectoryNode *getNodeByPath(QStringList path);
FileNode *getNodeById(int id) const;
[[nodiscard]] FileNode *getNodeById(int id) const;
};
class FileNode : public Node
{
@ -64,17 +64,17 @@ public:
: Node(_name, _parent), id(_id), uploadTime(_uploadTime)
{
}
int getId() const
[[nodiscard]] int getId() const
{
return id;
}
QDateTime getUploadTime() const
[[nodiscard]] QDateTime getUploadTime() const
{
return uploadTime;
}
};
template <typename T> T getNode(const QModelIndex &index) const
template <typename T> [[nodiscard]] T getNode(const QModelIndex &index) const
{
if (!index.isValid())
return dynamic_cast<T>(root);
@ -96,15 +96,16 @@ private slots:
public:
explicit RemoteDeckList_TreeModel(AbstractClient *_client, QObject *parent = nullptr);
~RemoteDeckList_TreeModel() override;
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override;
QVariant data(const QModelIndex &index, int role) const override;
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
QModelIndex parent(const QModelIndex &index) const override;
Qt::ItemFlags flags(const QModelIndex &index) const override;
[[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override;
[[nodiscard]] int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override;
[[nodiscard]] QVariant data(const QModelIndex &index, int role) const override;
[[nodiscard]] QVariant
headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
[[nodiscard]] QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
[[nodiscard]] QModelIndex parent(const QModelIndex &index) const override;
[[nodiscard]] Qt::ItemFlags flags(const QModelIndex &index) const override;
DirectoryNode *getRoot() const
[[nodiscard]] DirectoryNode *getRoot() const
{
return root;
}
@ -124,11 +125,11 @@ private:
public:
explicit RemoteDeckList_TreeWidget(AbstractClient *_client, QWidget *parent = nullptr);
RemoteDeckList_TreeModel::Node *getNode(const QModelIndex &ind) const;
RemoteDeckList_TreeModel::Node *getCurrentItem() const;
QList<RemoteDeckList_TreeModel::Node *> getCurrentSelection() const;
RemoteDeckList_TreeModel::DirectoryNode *getNodeByPath(const QString &path) const;
RemoteDeckList_TreeModel::FileNode *getNodeById(int id) const;
[[nodiscard]] RemoteDeckList_TreeModel::Node *getNode(const QModelIndex &ind) const;
[[nodiscard]] RemoteDeckList_TreeModel::Node *getCurrentItem() const;
[[nodiscard]] QList<RemoteDeckList_TreeModel::Node *> getCurrentSelection() const;
[[nodiscard]] RemoteDeckList_TreeModel::DirectoryNode *getNodeByPath(const QString &path) const;
[[nodiscard]] RemoteDeckList_TreeModel::FileNode *getNodeById(int id) const;
void addFileToTree(const ServerInfo_DeckStorage_TreeItem &file, RemoteDeckList_TreeModel::DirectoryNode *parent);
void addFolderToTree(const ServerInfo_DeckStorage_TreeItem &folder,
RemoteDeckList_TreeModel::DirectoryNode *parent);

31
cockatrice/src/interface/widgets/server/remote/remote_replay_list_tree_widget.h
View file

@ -35,7 +35,7 @@ private:
{
}
virtual ~Node() = default;
QString getName() const
[[nodiscard]] QString getName() const
{
return name;
}
@ -91,21 +91,22 @@ private slots:
public:
explicit RemoteReplayList_TreeModel(AbstractClient *_client, QObject *parent = nullptr);
~RemoteReplayList_TreeModel() override;
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override
[[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override;
[[nodiscard]] int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const override
{
return numberOfColumns;
}
QVariant data(const QModelIndex &index, int role) const override;
QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
QModelIndex parent(const QModelIndex &index) const override;
Qt::ItemFlags flags(const QModelIndex &index) const override;
[[nodiscard]] QVariant data(const QModelIndex &index, int role) const override;
[[nodiscard]] QVariant
headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
[[nodiscard]] QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
[[nodiscard]] QModelIndex parent(const QModelIndex &index) const override;
[[nodiscard]] Qt::ItemFlags flags(const QModelIndex &index) const override;
void clearTree();
void refreshTree();
ServerInfo_Replay const *getReplay(const QModelIndex &index) const;
ServerInfo_ReplayMatch const *getReplayMatch(const QModelIndex &index) const;
ServerInfo_ReplayMatch const *getEnclosingReplayMatch(const QModelIndex &index) const;
[[nodiscard]] ServerInfo_Replay const *getReplay(const QModelIndex &index) const;
[[nodiscard]] ServerInfo_ReplayMatch const *getReplayMatch(const QModelIndex &index) const;
[[nodiscard]] ServerInfo_ReplayMatch const *getEnclosingReplayMatch(const QModelIndex &index) const;
void addMatchInfo(const ServerInfo_ReplayMatch &matchInfo);
void updateMatchInfo(int gameId, const ServerInfo_ReplayMatch &matchInfo);
void removeMatchInfo(int gameId);
@ -119,10 +120,10 @@ private:
public:
explicit RemoteReplayList_TreeWidget(AbstractClient *_client, QWidget *parent = nullptr);
ServerInfo_Replay const *getReplay(const QModelIndex &ind) const;
ServerInfo_ReplayMatch const *getReplayMatch(const QModelIndex &ind) const;
QList<ServerInfo_Replay const *> getSelectedReplays() const;
QSet<ServerInfo_ReplayMatch const *> getSelectedReplayMatches() const;
[[nodiscard]] ServerInfo_Replay const *getReplay(const QModelIndex &ind) const;
[[nodiscard]] ServerInfo_ReplayMatch const *getReplayMatch(const QModelIndex &ind) const;
[[nodiscard]] QList<ServerInfo_Replay const *> getSelectedReplays() const;
[[nodiscard]] QSet<ServerInfo_ReplayMatch const *> getSelectedReplayMatches() const;
void clearTree()
{
treeModel->clearTree();

14
cockatrice/src/interface/widgets/server/user/user_info_connection.h
View file

@ -30,31 +30,31 @@ private:
public:
UserConnection_Information();
UserConnection_Information(QString, QString, QString, QString, QString, bool, QString);
QString getSaveName() const
[[nodiscard]] QString getSaveName() const
{
return saveName;
}
QString getServer() const
[[nodiscard]] QString getServer() const
{
return server;
}
QString getPort() const
[[nodiscard]] QString getPort() const
{
return port;
}
QString getUsername() const
[[nodiscard]] QString getUsername() const
{
return username;
}
QString getPassword() const
[[nodiscard]] QString getPassword() const
{
return password;
}
bool getSavePassword() const
[[nodiscard]] bool getSavePassword() const
{
return savePassword;
}
QString getSite() const
[[nodiscard]] QString getSite() const
{
return site;
}

10
cockatrice/src/interface/widgets/server/user/user_list_manager.h
View file

@ -60,11 +60,11 @@ public:
return ignoredUsers;
}
bool isOwnUserRegistered() const override;
QString getOwnUsername() const override;
bool isUserBuddy(const QString &userName) const override;
bool isUserIgnored(const QString &userName) const override;
const ServerInfo_User *getOnlineUser(const QString &userName) const override;
[[nodiscard]] bool isOwnUserRegistered() const override;
[[nodiscard]] QString getOwnUsername() const override;
[[nodiscard]] bool isUserBuddy(const QString &userName) const override;
[[nodiscard]] bool isUserIgnored(const QString &userName) const override;
[[nodiscard]] const ServerInfo_User *getOnlineUser(const QString &userName) const override;
public slots:
void handleConnect();

28
cockatrice/src/interface/widgets/server/user/user_list_widget.h
View file

@ -45,13 +45,13 @@ private slots:
public:
explicit BanDialog(const ServerInfo_User &info, QWidget *parent = nullptr);
QString getBanName() const;
QString getBanIP() const;
QString getBanId() const;
int getMinutes() const;
QString getReason() const;
QString getVisibleReason() const;
int getDeleteMessages() const;
[[nodiscard]] QString getBanName() const;
[[nodiscard]] QString getBanIP() const;
[[nodiscard]] QString getBanId() const;
[[nodiscard]] int getMinutes() const;
[[nodiscard]] QString getReason() const;
[[nodiscard]] QString getVisibleReason() const;
[[nodiscard]] int getDeleteMessages() const;
};
class WarningDialog : public QDialog
@ -68,10 +68,10 @@ private slots:
public:
WarningDialog(const QString userName, const QString clientID, QWidget *parent = nullptr);
QString getName() const;
QString getWarnID() const;
QString getReason() const;
int getDeleteMessages() const;
[[nodiscard]] QString getName() const;
[[nodiscard]] QString getWarnID() const;
[[nodiscard]] QString getReason() const;
[[nodiscard]] int getDeleteMessages() const;
void addWarningOption(const QString warning);
};
@ -85,11 +85,11 @@ private:
public:
explicit AdminNotesDialog(const QString &_userName, const QString &_notes, QWidget *_parent = nullptr);
QString getName() const
[[nodiscard]] QString getName() const
{
return userName;
}
QString getNotes() const;
[[nodiscard]] QString getNotes() const;
};
class UserListItemDelegate : public QStyledItemDelegate
@ -159,7 +159,7 @@ public:
void processUserInfo(const ServerInfo_User &user, bool online);
bool deleteUser(const QString &userName);
void setUserOnline(const QString &userName, bool online);
const QMap<QString, UserListTWI *> &getUsers() const
[[nodiscard]] const QMap<QString, UserListTWI *> &getUsers() const
{
return users;
}

12
cockatrice/src/interface/widgets/tabs/api/edhrec/api_response/cards/edhrec_api_response_card_container.h
View file

@ -29,27 +29,27 @@ public:
void debugPrint() const;
// Getter methods for deck container
const QString &getDescription() const
[[nodiscard]] const QString &getDescription() const
{
return description;
}
const QVector<QJsonObject> &getBreadcrumb() const
[[nodiscard]] const QVector<QJsonObject> &getBreadcrumb() const
{
return breadcrumb;
}
const EdhrecCommanderApiResponseCommanderDetails &getCommanderDetails() const
[[nodiscard]] const EdhrecCommanderApiResponseCommanderDetails &getCommanderDetails() const
{
return card;
}
const QVector<EdhrecApiResponseCardList> &getCardlists() const
[[nodiscard]] const QVector<EdhrecApiResponseCardList> &getCardlists() const
{
return cardlists;
}
const QString &getKeywords() const
[[nodiscard]] const QString &getKeywords() const
{
return keywords;
}
const QString &getTitle() const
[[nodiscard]] const QString &getTitle() const
{
return title;
}

58
cockatrice/src/interface/widgets/tabs/api/edhrec/api_response/cards/edhrec_commander_api_response_commander_details.h
View file

@ -27,119 +27,119 @@ public:
void debugPrint() const;
// Getters for the card data
const QString &getAetherhubUri() const
[[nodiscard]] const QString &getAetherhubUri() const
{
return aetherhubUri;
}
const QString &getArchidektUri() const
[[nodiscard]] const QString &getArchidektUri() const
{
return archidektUri;
}
int getCmc() const
[[nodiscard]] int getCmc() const
{
return cmc;
}
const QJsonArray &getColorIdentity() const
[[nodiscard]] const QJsonArray &getColorIdentity() const
{
return colorIdentity;
}
bool isCombos() const
[[nodiscard]] bool isCombos() const
{
return combos;
}
const QString &getDeckstatsUri() const
[[nodiscard]] const QString &getDeckstatsUri() const
{
return deckstatsUri;
}
const QVector<QString> &getImageUris() const
[[nodiscard]] const QVector<QString> &getImageUris() const
{
return imageUris;
}
int getInclusion() const
[[nodiscard]] int getInclusion() const
{
return inclusion;
}
bool getIsCommander() const
[[nodiscard]] bool getIsCommander() const
{
return isCommander;
}
const QString &getLabel() const
[[nodiscard]] const QString &getLabel() const
{
return label;
}
const QString &getLayout() const
[[nodiscard]] const QString &getLayout() const
{
return layout;
}
bool getLegalCommander() const
[[nodiscard]] bool getLegalCommander() const
{
return legalCommander;
}
const QString &getMoxfieldUri() const
[[nodiscard]] const QString &getMoxfieldUri() const
{
return moxfieldUri;
}
const QString &getMtggoldfishUri() const
[[nodiscard]] const QString &getMtggoldfishUri() const
{
return mtggoldfishUri;
}
const QString &getName() const
[[nodiscard]] const QString &getName() const
{
return name;
}
const QJsonArray &getNames() const
[[nodiscard]] const QJsonArray &getNames() const
{
return names;
}
int getNumDecks() const
[[nodiscard]] int getNumDecks() const
{
return numDecks;
}
int getPotentialDecks() const
[[nodiscard]] int getPotentialDecks() const
{
return potentialDecks;
}
const QString &getPrecon() const
[[nodiscard]] const QString &getPrecon() const
{
return precon;
}
const CardPrices &getPrices() const
[[nodiscard]] const CardPrices &getPrices() const
{
return prices;
}
const QString &getPrimaryType() const
[[nodiscard]] const QString &getPrimaryType() const
{
return primaryType;
}
const QString &getRarity() const
[[nodiscard]] const QString &getRarity() const
{
return rarity;
}
double getSalt() const
[[nodiscard]] double getSalt() const
{
return salt;
}
const QString &getSanitized() const
[[nodiscard]] const QString &getSanitized() const
{
return sanitized;
}
const QString &getSanitizedWo() const
[[nodiscard]] const QString &getSanitizedWo() const
{
return sanitizedWo;
}
const QString &getScryfallUri() const
[[nodiscard]] const QString &getScryfallUri() const
{
return scryfallUri;
}
const QString &getSpellbookUri() const
[[nodiscard]] const QString &getSpellbookUri() const
{
return spellbookUri;
}
const QString &getType() const
[[nodiscard]] const QString &getType() const
{
return type;
}
const QString &getUrl() const
[[nodiscard]] const QString &getUrl() const
{
return url;
}

4
cockatrice/src/interface/widgets/tabs/api/edhrec/tab_edhrec_main.h
View file

@ -27,13 +27,13 @@ public:
void retranslateUi() override;
void doSearch();
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
auto cardName = cardToQuery.isNull() ? QString() : cardToQuery->getName();
return tr("EDHRec: ") + cardName;
}
CardSizeWidget *getCardSizeSlider()
CardSizeWidget *getCardSizeSlider() const
{
return cardSizeSlider;
}

8
cockatrice/src/interface/widgets/tabs/tab.h
View file

@ -39,15 +39,15 @@ private:
public:
explicit Tab(TabSupervisor *_tabSupervisor);
const QList<QMenu *> &getTabMenus() const
[[nodiscard]] const QList<QMenu *> &getTabMenus() const
{
return tabMenus;
}
TabSupervisor *getTabSupervisor() const
[[nodiscard]] TabSupervisor *getTabSupervisor() const
{
return tabSupervisor;
}
bool getContentsChanged() const
[[nodiscard]] bool getContentsChanged() const
{
return contentsChanged;
}
@ -55,7 +55,7 @@ public:
{
contentsChanged = _contentsChanged;
}
virtual QString getTabText() const = 0;
[[nodiscard]] virtual QString getTabText() const = 0;
virtual void retranslateUi() = 0;
/**

2
cockatrice/src/interface/widgets/tabs/tab_home.h
View file

@ -26,7 +26,7 @@ private:
public:
TabHome(TabSupervisor *_tabSupervisor, AbstractClient *_client);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Home");
}

4
cockatrice/src/interface/widgets/tabs/tab_message.h
View file

@ -54,8 +54,8 @@ public:
~TabMessage() override;
void retranslateUi() override;
void tabActivated() override;
QString getUserName() const;
QString getTabText() const override;
[[nodiscard]] QString getUserName() const;
[[nodiscard]] QString getTabText() const override;
void processUserMessageEvent(const Event_UserMessage &event);

6
cockatrice/src/interface/widgets/visual_deck_storage/deck_preview/deck_preview_tag_display_widget.h
View file

@ -30,12 +30,12 @@ public:
* @param tagName The name of the tag to display.
*/
explicit DeckPreviewTagDisplayWidget(QWidget *parent = nullptr, const QString &tagName = "");
QSize sizeHint() const override;
QString getTagName() const
[[nodiscard]] QSize sizeHint() const override;
[[nodiscard]] QString getTagName() const
{
return tagName;
}
TagState getState() const
[[nodiscard]] TagState getState() const
{
return state;
}