jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-22 09:35:08 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[Fix-Warnings] Mark const getters as [[nodiscard]] (#6365)

Browse source 
Took 45 minutes

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2025-11-28 21:38:54 +01:00 • committed by GitHub
parent a1a3b02d3a
commit 9ece4bfd9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
58 changed files with 548 additions and 543 deletions
Download patch file Download diff file Expand all files Collapse all files

14
cockatrice/src/interface/widgets/server/user/user_info_connection.h
View file

@ -30,31 +30,31 @@ private:
public:
UserConnection_Information();
UserConnection_Information(QString, QString, QString, QString, QString, bool, QString);
QString getSaveName() const
[[nodiscard]] QString getSaveName() const
{
return saveName;
}
QString getServer() const
[[nodiscard]] QString getServer() const
{
return server;
}
QString getPort() const
[[nodiscard]] QString getPort() const
{
return port;
}
QString getUsername() const
[[nodiscard]] QString getUsername() const
{
return username;
}
QString getPassword() const
[[nodiscard]] QString getPassword() const
{
return password;
}
bool getSavePassword() const
[[nodiscard]] bool getSavePassword() const
{
return savePassword;
}
QString getSite() const
[[nodiscard]] QString getSite() const
{
return site;
}

10
cockatrice/src/interface/widgets/server/user/user_list_manager.h
View file

@ -60,11 +60,11 @@ public:
return ignoredUsers;
}
bool isOwnUserRegistered() const override;
QString getOwnUsername() const override;
bool isUserBuddy(const QString &userName) const override;
bool isUserIgnored(const QString &userName) const override;
const ServerInfo_User *getOnlineUser(const QString &userName) const override;
[[nodiscard]] bool isOwnUserRegistered() const override;
[[nodiscard]] QString getOwnUsername() const override;
[[nodiscard]] bool isUserBuddy(const QString &userName) const override;
[[nodiscard]] bool isUserIgnored(const QString &userName) const override;
[[nodiscard]] const ServerInfo_User *getOnlineUser(const QString &userName) const override;
public slots:
void handleConnect();

28
cockatrice/src/interface/widgets/server/user/user_list_widget.h
View file

@ -45,13 +45,13 @@ private slots:
public:
explicit BanDialog(const ServerInfo_User &info, QWidget *parent = nullptr);
QString getBanName() const;
QString getBanIP() const;
QString getBanId() const;
int getMinutes() const;
QString getReason() const;
QString getVisibleReason() const;
int getDeleteMessages() const;
[[nodiscard]] QString getBanName() const;
[[nodiscard]] QString getBanIP() const;
[[nodiscard]] QString getBanId() const;
[[nodiscard]] int getMinutes() const;
[[nodiscard]] QString getReason() const;
[[nodiscard]] QString getVisibleReason() const;
[[nodiscard]] int getDeleteMessages() const;
};
class WarningDialog : public QDialog
@ -68,10 +68,10 @@ private slots:
public:
WarningDialog(const QString userName, const QString clientID, QWidget *parent = nullptr);
QString getName() const;
QString getWarnID() const;
QString getReason() const;
int getDeleteMessages() const;
[[nodiscard]] QString getName() const;
[[nodiscard]] QString getWarnID() const;
[[nodiscard]] QString getReason() const;
[[nodiscard]] int getDeleteMessages() const;
void addWarningOption(const QString warning);
};
@ -85,11 +85,11 @@ private:
public:
explicit AdminNotesDialog(const QString &_userName, const QString &_notes, QWidget *_parent = nullptr);
QString getName() const
[[nodiscard]] QString getName() const
{
return userName;
}
QString getNotes() const;
[[nodiscard]] QString getNotes() const;
};
class UserListItemDelegate : public QStyledItemDelegate
@ -159,7 +159,7 @@ public:
void processUserInfo(const ServerInfo_User &user, bool online);
bool deleteUser(const QString &userName);
void setUserOnline(const QString &userName, bool online);
const QMap<QString, UserListTWI *> &getUsers() const
[[nodiscard]] const QMap<QString, UserListTWI *> &getUsers() const
{
return users;
}