jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-12 00:54:53 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[Fix-Warnings] Mark const getters as [[nodiscard]] (#6365)

Browse source 
Took 45 minutes

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2025-11-28 21:38:54 +01:00 • committed by GitHub
parent a1a3b02d3a
commit 9ece4bfd9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
58 changed files with 548 additions and 543 deletions
Download patch file Download diff file Expand all files Collapse all files

12
cockatrice/src/interface/widgets/tabs/api/edhrec/api_response/cards/edhrec_api_response_card_container.h
View file

@ -29,27 +29,27 @@ public:
void debugPrint() const;
// Getter methods for deck container
const QString &getDescription() const
[[nodiscard]] const QString &getDescription() const
{
return description;
}
const QVector<QJsonObject> &getBreadcrumb() const
[[nodiscard]] const QVector<QJsonObject> &getBreadcrumb() const
{
return breadcrumb;
}
const EdhrecCommanderApiResponseCommanderDetails &getCommanderDetails() const
[[nodiscard]] const EdhrecCommanderApiResponseCommanderDetails &getCommanderDetails() const
{
return card;
}
const QVector<EdhrecApiResponseCardList> &getCardlists() const
[[nodiscard]] const QVector<EdhrecApiResponseCardList> &getCardlists() const
{
return cardlists;
}
const QString &getKeywords() const
[[nodiscard]] const QString &getKeywords() const
{
return keywords;
}
const QString &getTitle() const
[[nodiscard]] const QString &getTitle() const
{
return title;
}

58
cockatrice/src/interface/widgets/tabs/api/edhrec/api_response/cards/edhrec_commander_api_response_commander_details.h
View file

@ -27,119 +27,119 @@ public:
void debugPrint() const;
// Getters for the card data
const QString &getAetherhubUri() const
[[nodiscard]] const QString &getAetherhubUri() const
{
return aetherhubUri;
}
const QString &getArchidektUri() const
[[nodiscard]] const QString &getArchidektUri() const
{
return archidektUri;
}
int getCmc() const
[[nodiscard]] int getCmc() const
{
return cmc;
}
const QJsonArray &getColorIdentity() const
[[nodiscard]] const QJsonArray &getColorIdentity() const
{
return colorIdentity;
}
bool isCombos() const
[[nodiscard]] bool isCombos() const
{
return combos;
}
const QString &getDeckstatsUri() const
[[nodiscard]] const QString &getDeckstatsUri() const
{
return deckstatsUri;
}
const QVector<QString> &getImageUris() const
[[nodiscard]] const QVector<QString> &getImageUris() const
{
return imageUris;
}
int getInclusion() const
[[nodiscard]] int getInclusion() const
{
return inclusion;
}
bool getIsCommander() const
[[nodiscard]] bool getIsCommander() const
{
return isCommander;
}
const QString &getLabel() const
[[nodiscard]] const QString &getLabel() const
{
return label;
}
const QString &getLayout() const
[[nodiscard]] const QString &getLayout() const
{
return layout;
}
bool getLegalCommander() const
[[nodiscard]] bool getLegalCommander() const
{
return legalCommander;
}
const QString &getMoxfieldUri() const
[[nodiscard]] const QString &getMoxfieldUri() const
{
return moxfieldUri;
}
const QString &getMtggoldfishUri() const
[[nodiscard]] const QString &getMtggoldfishUri() const
{
return mtggoldfishUri;
}
const QString &getName() const
[[nodiscard]] const QString &getName() const
{
return name;
}
const QJsonArray &getNames() const
[[nodiscard]] const QJsonArray &getNames() const
{
return names;
}
int getNumDecks() const
[[nodiscard]] int getNumDecks() const
{
return numDecks;
}
int getPotentialDecks() const
[[nodiscard]] int getPotentialDecks() const
{
return potentialDecks;
}
const QString &getPrecon() const
[[nodiscard]] const QString &getPrecon() const
{
return precon;
}
const CardPrices &getPrices() const
[[nodiscard]] const CardPrices &getPrices() const
{
return prices;
}
const QString &getPrimaryType() const
[[nodiscard]] const QString &getPrimaryType() const
{
return primaryType;
}
const QString &getRarity() const
[[nodiscard]] const QString &getRarity() const
{
return rarity;
}
double getSalt() const
[[nodiscard]] double getSalt() const
{
return salt;
}
const QString &getSanitized() const
[[nodiscard]] const QString &getSanitized() const
{
return sanitized;
}
const QString &getSanitizedWo() const
[[nodiscard]] const QString &getSanitizedWo() const
{
return sanitizedWo;
}
const QString &getScryfallUri() const
[[nodiscard]] const QString &getScryfallUri() const
{
return scryfallUri;
}
const QString &getSpellbookUri() const
[[nodiscard]] const QString &getSpellbookUri() const
{
return spellbookUri;
}
const QString &getType() const
[[nodiscard]] const QString &getType() const
{
return type;
}
const QString &getUrl() const
[[nodiscard]] const QString &getUrl() const
{
return url;
}

4
cockatrice/src/interface/widgets/tabs/api/edhrec/tab_edhrec_main.h
View file

@ -27,13 +27,13 @@ public:
void retranslateUi() override;
void doSearch();
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
auto cardName = cardToQuery.isNull() ? QString() : cardToQuery->getName();
return tr("EDHRec: ") + cardName;
}
CardSizeWidget *getCardSizeSlider()
CardSizeWidget *getCardSizeSlider() const
{
return cardSizeSlider;
}

8
cockatrice/src/interface/widgets/tabs/tab.h
View file

@ -39,15 +39,15 @@ private:
public:
explicit Tab(TabSupervisor *_tabSupervisor);
const QList<QMenu *> &getTabMenus() const
[[nodiscard]] const QList<QMenu *> &getTabMenus() const
{
return tabMenus;
}
TabSupervisor *getTabSupervisor() const
[[nodiscard]] TabSupervisor *getTabSupervisor() const
{
return tabSupervisor;
}
bool getContentsChanged() const
[[nodiscard]] bool getContentsChanged() const
{
return contentsChanged;
}
@ -55,7 +55,7 @@ public:
{
contentsChanged = _contentsChanged;
}
virtual QString getTabText() const = 0;
[[nodiscard]] virtual QString getTabText() const = 0;
virtual void retranslateUi() = 0;
/**

2
cockatrice/src/interface/widgets/tabs/tab_home.h
View file

@ -26,7 +26,7 @@ private:
public:
TabHome(TabSupervisor *_tabSupervisor, AbstractClient *_client);
void retranslateUi() override;
QString getTabText() const override
[[nodiscard]] QString getTabText() const override
{
return tr("Home");
}

4
cockatrice/src/interface/widgets/tabs/tab_message.h
View file

@ -54,8 +54,8 @@ public:
~TabMessage() override;
void retranslateUi() override;
void tabActivated() override;
QString getUserName() const;
QString getTabText() const override;
[[nodiscard]] QString getUserName() const;
[[nodiscard]] QString getTabText() const override;
void processUserMessageEvent(const Event_UserMessage &event);