[Fix-Warnings] Mark const getters as [[nodiscard]] (#6365)

Took 45 minutes

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2025-11-28 21:38:54 +01:00 committed by GitHub
parent a1a3b02d3a
commit 9ece4bfd9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
58 changed files with 548 additions and 543 deletions

View file

@ -9,10 +9,10 @@ class ICardDatabasePathProvider : public QObject
public:
virtual ~ICardDatabasePathProvider() = default;
virtual QString getCardDatabasePath() const = 0;
virtual QString getCustomCardDatabasePath() const = 0;
virtual QString getTokenDatabasePath() const = 0;
virtual QString getSpoilerCardDatabasePath() const = 0;
[[nodiscard]] virtual QString getCardDatabasePath() const = 0;
[[nodiscard]] virtual QString getCustomCardDatabasePath() const = 0;
[[nodiscard]] virtual QString getTokenDatabasePath() const = 0;
[[nodiscard]] virtual QString getSpoilerCardDatabasePath() const = 0;
signals:
void cardDatabasePathChanged();

View file

@ -7,8 +7,8 @@ class ICardPreferenceProvider
{
public:
virtual ~ICardPreferenceProvider() = default;
virtual QString getCardPreferenceOverride(const QString &cardName) const = 0;
virtual bool getIncludeRebalancedCards() const = 0;
[[nodiscard]] virtual QString getCardPreferenceOverride(const QString &cardName) const = 0;
[[nodiscard]] virtual bool getIncludeRebalancedCards() const = 0;
};
#endif // COCKATRICE_INTERFACE_CARD_PREFERENCE_PROVIDER_H

View file

@ -5,19 +5,19 @@
class NoopCardDatabasePathProvider : public ICardDatabasePathProvider
{
public:
QString getCardDatabasePath() const override
[[nodiscard]] QString getCardDatabasePath() const override
{
return "";
}
QString getCustomCardDatabasePath() const override
[[nodiscard]] QString getCustomCardDatabasePath() const override
{
return "";
}
QString getTokenDatabasePath() const override
[[nodiscard]] QString getTokenDatabasePath() const override
{
return "";
}
QString getSpoilerCardDatabasePath() const override
[[nodiscard]] QString getSpoilerCardDatabasePath() const override
{
return "";
}

View file

@ -5,12 +5,12 @@
class NoopCardPreferenceProvider : public ICardPreferenceProvider
{
public:
QString getCardPreferenceOverride(const QString &) const override
[[nodiscard]] QString getCardPreferenceOverride(const QString &) const override
{
return {};
}
bool getIncludeRebalancedCards() const override
[[nodiscard]] bool getIncludeRebalancedCards() const override
{
return true;
}