From 9f729bf6368885db027bca7af390e95ee69ad401 Mon Sep 17 00:00:00 2001
From: RickyRister <42636155+RickyRister@users.noreply.github.com>
Date: Sat, 25 Jan 2025 06:04:26 -0800
Subject: [PATCH] add missing override and explicit specifiers in src/dialogs
 (#5524)

---
 cockatrice/src/dialogs/dlg_create_token.h              | 2 +-
 cockatrice/src/dialogs/dlg_edit_avatar.h               | 2 +-
 cockatrice/src/dialogs/dlg_edit_password.h             | 2 +-
 cockatrice/src/dialogs/dlg_edit_user.h                 | 8 ++++----
 cockatrice/src/dialogs/dlg_forgot_password_challenge.h | 2 +-
 cockatrice/src/dialogs/dlg_forgot_password_request.h   | 2 +-
 cockatrice/src/dialogs/dlg_forgot_password_reset.h     | 2 +-
 cockatrice/src/dialogs/dlg_load_remote_deck.h          | 2 +-
 cockatrice/src/dialogs/dlg_manage_sets.h               | 4 ++--
 cockatrice/src/dialogs/dlg_register.h                  | 2 +-
 cockatrice/src/dialogs/dlg_update.h                    | 2 +-
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/cockatrice/src/dialogs/dlg_create_token.h b/cockatrice/src/dialogs/dlg_create_token.h
index dec17109e..a226faaca 100644
--- a/cockatrice/src/dialogs/dlg_create_token.h
+++ b/cockatrice/src/dialogs/dlg_create_token.h
@@ -21,7 +21,7 @@ class DlgCreateToken : public QDialog
 {
     Q_OBJECT
 public:
-    DlgCreateToken(const QStringList &_predefinedTokens, QWidget *parent = nullptr);
+    explicit DlgCreateToken(const QStringList &_predefinedTokens, QWidget *parent = nullptr);
     QString getName() const;
     QString getColor() const;
     QString getPT() const;
diff --git a/cockatrice/src/dialogs/dlg_edit_avatar.h b/cockatrice/src/dialogs/dlg_edit_avatar.h
index 604650fa2..8a84349e2 100644
--- a/cockatrice/src/dialogs/dlg_edit_avatar.h
+++ b/cockatrice/src/dialogs/dlg_edit_avatar.h
@@ -16,7 +16,7 @@ class DlgEditAvatar : public QDialog
 {
     Q_OBJECT
 public:
-    DlgEditAvatar(QWidget *parent = nullptr);
+    explicit DlgEditAvatar(QWidget *parent = nullptr);
     QByteArray getImage();
 private slots:
     void actOk();
diff --git a/cockatrice/src/dialogs/dlg_edit_password.h b/cockatrice/src/dialogs/dlg_edit_password.h
index 4fab9c8c7..e3fcce6ec 100644
--- a/cockatrice/src/dialogs/dlg_edit_password.h
+++ b/cockatrice/src/dialogs/dlg_edit_password.h
@@ -13,7 +13,7 @@ class DlgEditPassword : public QDialog
 {
     Q_OBJECT
 public:
-    DlgEditPassword(QWidget *parent = nullptr);
+    explicit DlgEditPassword(QWidget *parent = nullptr);
     QString getOldPassword() const
     {
         return oldPasswordEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_edit_user.h b/cockatrice/src/dialogs/dlg_edit_user.h
index 3dc6c7ebc..db2ca60ac 100644
--- a/cockatrice/src/dialogs/dlg_edit_user.h
+++ b/cockatrice/src/dialogs/dlg_edit_user.h
@@ -13,10 +13,10 @@ class DlgEditUser : public QDialog
 {
     Q_OBJECT
 public:
-    DlgEditUser(QWidget *parent = nullptr,
-                QString email = QString(),
-                QString country = QString(),
-                QString realName = QString());
+    explicit DlgEditUser(QWidget *parent = nullptr,
+                         QString email = QString(),
+                         QString country = QString(),
+                         QString realName = QString());
     QString getEmail() const
     {
         return emailEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_forgot_password_challenge.h b/cockatrice/src/dialogs/dlg_forgot_password_challenge.h
index 34aa237bd..73fb44c33 100644
--- a/cockatrice/src/dialogs/dlg_forgot_password_challenge.h
+++ b/cockatrice/src/dialogs/dlg_forgot_password_challenge.h
@@ -13,7 +13,7 @@ class DlgForgotPasswordChallenge : public QDialog
 {
     Q_OBJECT
 public:
-    DlgForgotPasswordChallenge(QWidget *parent = nullptr);
+    explicit DlgForgotPasswordChallenge(QWidget *parent = nullptr);
     QString getHost() const
     {
         return hostEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_forgot_password_request.h b/cockatrice/src/dialogs/dlg_forgot_password_request.h
index c423444c0..8d267042a 100644
--- a/cockatrice/src/dialogs/dlg_forgot_password_request.h
+++ b/cockatrice/src/dialogs/dlg_forgot_password_request.h
@@ -13,7 +13,7 @@ class DlgForgotPasswordRequest : public QDialog
 {
     Q_OBJECT
 public:
-    DlgForgotPasswordRequest(QWidget *parent = nullptr);
+    explicit DlgForgotPasswordRequest(QWidget *parent = nullptr);
     QString getHost() const
     {
         return hostEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_forgot_password_reset.h b/cockatrice/src/dialogs/dlg_forgot_password_reset.h
index ed018ee7f..e523e19c3 100644
--- a/cockatrice/src/dialogs/dlg_forgot_password_reset.h
+++ b/cockatrice/src/dialogs/dlg_forgot_password_reset.h
@@ -13,7 +13,7 @@ class DlgForgotPasswordReset : public QDialog
 {
     Q_OBJECT
 public:
-    DlgForgotPasswordReset(QWidget *parent = nullptr);
+    explicit DlgForgotPasswordReset(QWidget *parent = nullptr);
     QString getHost() const
     {
         return hostEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_load_remote_deck.h b/cockatrice/src/dialogs/dlg_load_remote_deck.h
index 61dcd7a61..54be44c77 100644
--- a/cockatrice/src/dialogs/dlg_load_remote_deck.h
+++ b/cockatrice/src/dialogs/dlg_load_remote_deck.h
@@ -20,7 +20,7 @@ private slots:
     void currentItemChanged(const QModelIndex &current, const QModelIndex &previous);
 
 public:
-    DlgLoadRemoteDeck(AbstractClient *_client, QWidget *parent = nullptr);
+    explicit DlgLoadRemoteDeck(AbstractClient *_client, QWidget *parent = nullptr);
     int getDeckId() const;
 };
 
diff --git a/cockatrice/src/dialogs/dlg_manage_sets.h b/cockatrice/src/dialogs/dlg_manage_sets.h
index 079057bfb..e974f67f9 100644
--- a/cockatrice/src/dialogs/dlg_manage_sets.h
+++ b/cockatrice/src/dialogs/dlg_manage_sets.h
@@ -51,8 +51,8 @@ private:
     };
 
 public:
-    WndSets(QWidget *parent = nullptr);
-    ~WndSets();
+    explicit WndSets(QWidget *parent = nullptr);
+    ~WndSets() override;
 
 protected:
     void selectRows(QSet<int> rows);
diff --git a/cockatrice/src/dialogs/dlg_register.h b/cockatrice/src/dialogs/dlg_register.h
index 51dd593a5..1d87212bf 100644
--- a/cockatrice/src/dialogs/dlg_register.h
+++ b/cockatrice/src/dialogs/dlg_register.h
@@ -13,7 +13,7 @@ class DlgRegister : public QDialog
 {
     Q_OBJECT
 public:
-    DlgRegister(QWidget *parent = nullptr);
+    explicit DlgRegister(QWidget *parent = nullptr);
     QString getHost() const
     {
         return hostEdit->text();
diff --git a/cockatrice/src/dialogs/dlg_update.h b/cockatrice/src/dialogs/dlg_update.h
index e4415283e..0fb254cb7 100644
--- a/cockatrice/src/dialogs/dlg_update.h
+++ b/cockatrice/src/dialogs/dlg_update.h
@@ -16,7 +16,7 @@ class DlgUpdate : public QDialog
 {
     Q_OBJECT
 public:
-    DlgUpdate(QWidget *parent);
+    explicit DlgUpdate(QWidget *parent);
 
 private slots:
     void finishedUpdateCheck(bool needToUpdate, bool isCompatible, Release *release);