jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-04-27 07:48:01 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Always set TabSupervisor as parent in Tab subclasses (#5449)

Browse source 
* refactor closeTab

* always set tab parent to tabSupervisor

* set tabSupervisor parent

* use close instead of deleteLater

* be more clear about overloads
This commit is contained in:
RickyRister 2025-01-11 23:34:11 -08:00 • committed by GitHub
parent 3a4ec1062b
commit a6fc88c79a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 25 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

5
cockatrice/src/client/tabs/tab_deck_editor.cpp
View file

@ -698,8 +698,7 @@ void TabDeckEditor::loadLayout()
QTimer::singleShot(100, this, SLOT(freeDocksSize()));
}
TabDeckEditor::TabDeckEditor(TabSupervisor *_tabSupervisor, QWidget *parent)
: Tab(_tabSupervisor, parent), modified(false)
TabDeckEditor::TabDeckEditor(TabSupervisor *_tabSupervisor) : Tab(_tabSupervisor), modified(false)
{
setObjectName("TabDeckEditor");
@ -982,7 +981,7 @@ void TabDeckEditor::closeRequest(bool forced)
}
emit deckEditorClosing(this);
deleteLater();
close();
}
void TabDeckEditor::actNewDeck()