Clean up inter-library dependencies with interfaces (#6280)

* Have CardDatabase::getPreferredPrintingInfo respect card provider ID overrides (pinned printings)

Took 13 minutes

Took 37 seconds

Took 10 seconds

Took 10 seconds

# Commit time for manual adjustment:
# Took 30 seconds

Took 15 seconds


Took 8 minutes

Took 21 seconds

* Move settings cache and settings card preference provider out of libcockatrice_settings and into cockatrice

Took 52 minutes

Took 9 minutes

Took 1 minute

* Temp cache.

Took 16 minutes

* Dependency Injection for SettingsCache

* Turn SettingsCache into a QSharedPointer.
* Implement interfaces for settings that need it

Took 2 hours 38 minutes

* Adjust oracle.

Took 5 minutes

* Move abstract/noop interfaces to libcockatrice_interfaces so they can be linked against independently.

Took 52 minutes

* Clean up some links.

Took 3 minutes

* Cleanup two includes.

Took 3 minutes

* More fixes.

Took 7 minutes

* More includes that slipped past.

Took 3 minutes

* Stop mocking and start injecting for tests.

Took 15 minutes

* I don't know why remote_client was including main.

Took 4 minutes

* Include.

Took 3 minutes

* Lint.

Took 2 minutes

* Don't use Qt pointers.

Took 1 hour 7 minutes

* Make parser use CardSettingsInterface

Took 13 minutes

* Also adjust constructor lol.

Took 8 minutes

* Lint.

Took 32 minutes

* Revert "Lint."

This reverts commit ecb596c39e.


Took 3 minutes

* Test.

Took 3 minutes

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>

cockatrice/src/interface/widgets/cards/additional_info/color_identity_widget.cpp

@@ -1,5 +1,6 @@
 #include "color_identity_widget.h"
 
+#include "../../../../client/settings/cache_settings.h"
 #include "mana_symbol_widget.h"
 
 #include <QHBoxLayout>
@@ -8,7 +9,6 @@
 #include <QRegularExpression>
 #include <QResizeEvent>
 #include <QSize>
-#include <libcockatrice/settings/cache_settings.h>
 
 ColorIdentityWidget::ColorIdentityWidget(QWidget *parent, CardInfoPtr _card) : QWidget(parent), card(_card)
 {

cockatrice/src/interface/widgets/cards/additional_info/mana_symbol_widget.cpp

@@ -1,7 +1,8 @@
 #include "mana_symbol_widget.h"
 
+#include "../../../../client/settings/cache_settings.h"
+
 #include <QResizeEvent>
-#include <libcockatrice/settings/cache_settings.h>
 
 ManaSymbolWidget::ManaSymbolWidget(QWidget *parent, QString _symbol, bool _isActive, bool _mayBeToggled)
     : QLabel(parent), symbol(_symbol), isActive(_isActive), mayBeToggled(_mayBeToggled)

cockatrice/src/interface/widgets/cards/card_info_frame_widget.cpp

@@ -1,5 +1,6 @@
 #include "card_info_frame_widget.h"
 
+#include "../../../client/settings/cache_settings.h"
 #include "../../../game/board/card_item.h"
 #include "card_info_display_widget.h"
 #include "card_info_picture_widget.h"
@@ -9,7 +10,6 @@
 #include <QVBoxLayout>
 #include <libcockatrice/card/database/card_database_manager.h>
 #include <libcockatrice/card/relation/card_relation.h>
-#include <libcockatrice/settings/cache_settings.h>
 #include <utility>
 
 CardInfoFrameWidget::CardInfoFrameWidget(QWidget *parent)

cockatrice/src/interface/widgets/cards/card_info_picture_enlarged_widget.cpp

@@ -1,10 +1,10 @@
 #include "card_info_picture_enlarged_widget.h"
 
+#include "../../../client/settings/cache_settings.h"
 #include "../../../interface/card_picture_loader/card_picture_loader.h"
 
 #include <QPainterPath>
 #include <QStylePainter>
-#include <libcockatrice/settings/cache_settings.h>
 #include <utility>
 
 /**

cockatrice/src/interface/widgets/cards/card_info_picture_widget.cpp

@@ -1,5 +1,6 @@
 #include "card_info_picture_widget.h"
 
+#include "../../../client/settings/cache_settings.h"
 #include "../../../game/board/card_item.h"
 #include "../../../interface/card_picture_loader/card_picture_loader.h"
 #include "../../../interface/widgets/tabs/tab_supervisor.h"
@@ -12,7 +13,6 @@
 #include <QWidget>
 #include <libcockatrice/card/database/card_database_manager.h>
 #include <libcockatrice/card/relation/card_relation.h>
-#include <libcockatrice/settings/cache_settings.h>
 #include <utility>
 
 /**

cockatrice/src/interface/widgets/cards/card_size_widget.cpp

@@ -1,10 +1,9 @@
 #include "card_size_widget.h"
 
+#include "../../../client/settings/cache_settings.h"
 #include "../printing_selector/printing_selector.h"
 #include "../visual_deck_storage/visual_deck_storage_widget.h"
 
-#include <libcockatrice/settings/cache_settings.h>
-
 /**
  * @class CardSizeWidget
  * @brief A widget for adjusting card sizes using a slider.

cockatrice/src/interface/widgets/cards/deck_preview_card_picture_widget.cpp

@@ -1,5 +1,7 @@
 #include "deck_preview_card_picture_widget.h"
 
+#include "../../../client/settings/cache_settings.h"
+
 #include <QApplication>
 #include <QFileInfo>
 #include <QFontMetrics>
@@ -7,7 +9,6 @@
 #include <QPainterPath>
 #include <QStylePainter>
 #include <QTextOption>
-#include <libcockatrice/settings/cache_settings.h>
 
 /**
  * @brief Constructs a CardPictureWithTextOverlay widget.