Refactor: Represent cardName + providerId with CardRef struct (#6039)

* card_ref.h

* update CardDatabase signatures

* make everything compile

* rename methods

* add docs

* mark stuff const

* set cardRef in CardItem

* cleanup

* fix build failure

* Fix builds on mac

---------

Co-authored-by: ZeldaZach <zahalpern+github@gmail.com>
This commit is contained in:
RickyRister 2025-07-15 19:14:02 -07:00 committed by GitHub
parent e05dad4267
commit a9b3be33e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
61 changed files with 328 additions and 305 deletions

24
common/card_ref.h Normal file
View file

@ -0,0 +1,24 @@
#ifndef CARD_REF_H
#define CARD_REF_H
#include <QString>
/**
* The information passed over the server that is required to identify the exact card to display.
*
* @param name The name of the card. Should not be empty, unless to indicate the lack of a card.
* @param providerId Determines which printing of the card to use. Can be empty, in which case Cockatrice should default
* to using the preferred set.
*/
struct CardRef
{
QString name;
QString providerId = QString();
bool operator==(const CardRef &other) const
{
return name == other.name && providerId == other.providerId;
}
};
#endif // CARD_REF_H