remove default args to prevent similar bugs in the future

This commit is contained in:
RickyRister 2024-12-18 23:30:43 -08:00
parent 05a6e67b13
commit a9e5a99b0c

View file

@ -202,17 +202,17 @@ private:
bool upsideDownArt; bool upsideDownArt;
public: public:
explicit CardInfo(const QString &_name = QString(), explicit CardInfo(const QString &_name,
const QString &_text = QString(), const QString &_text,
bool _isToken = false, bool _isToken,
QVariantHash _properties = QVariantHash(), QVariantHash _properties,
const QList<CardRelation *> &_relatedCards = QList<CardRelation *>(), const QList<CardRelation *> &_relatedCards,
const QList<CardRelation *> &_reverseRelatedCards = QList<CardRelation *>(), const QList<CardRelation *> &_reverseRelatedCards,
CardInfoPerSetMap _sets = CardInfoPerSetMap(), CardInfoPerSetMap _sets,
bool _cipt = false, bool _cipt,
bool _landscapeOrientation = false, bool _landscapeOrientation,
int _tableRow = 0, int _tableRow,
bool _upsideDownArt = false); bool _upsideDownArt);
CardInfo(const CardInfo &other) CardInfo(const CardInfo &other)
: QObject(other.parent()), name(other.name), simpleName(other.simpleName), pixmapCacheKey(other.pixmapCacheKey), : QObject(other.parent()), name(other.name), simpleName(other.simpleName), pixmapCacheKey(other.pixmapCacheKey),
text(other.text), isToken(other.isToken), properties(other.properties), relatedCards(other.relatedCards), text(other.text), isToken(other.isToken), properties(other.properties), relatedCards(other.relatedCards),
@ -223,17 +223,17 @@ public:
} }
~CardInfo() override; ~CardInfo() override;
static CardInfoPtr newInstance(const QString &_name = QString(), static CardInfoPtr newInstance(const QString &_name,
const QString &_text = QString(), const QString &_text,
bool _isToken = false, bool _isToken,
QVariantHash _properties = QVariantHash(), QVariantHash _properties,
const QList<CardRelation *> &_relatedCards = QList<CardRelation *>(), const QList<CardRelation *> &_relatedCards,
const QList<CardRelation *> &_reverseRelatedCards = QList<CardRelation *>(), const QList<CardRelation *> &_reverseRelatedCards,
CardInfoPerSetMap _sets = CardInfoPerSetMap(), CardInfoPerSetMap _sets,
bool _cipt = false, bool _cipt,
bool _landscapeOrientation = false, bool _landscapeOrientation,
int _tableRow = 0, int _tableRow,
bool _upsideDownArt = false); bool _upsideDownArt);
CardInfoPtr clone() const CardInfoPtr clone() const
{ {