jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-21 09:05:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[Client] Exit deterministically when launching the update installer

Browse source
This commit is contained in:
Lukas Brübach 2026-09-17 20:31:13 +02:00 • committed by GitHub
parent 8ceb363f07
commit b3dcabb680
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cockatrice/src/interface/widgets/dialogs/dlg_update.cpp
View file

@ -5,11 +5,13 @@
#include "../client/network/update/client/release_channel.h"
#include "../interface/window_main.h"
#include <QCoreApplication>
#include <QDesktopServices>
#include <QLabel>
#include <QMessageBox>
#include <QProgressBar>
#include <QPushButton>
#include <QTimer>
#include <QVBoxLayout>
#include <QtNetwork>
#include <version_string.h>
@ -240,8 +242,14 @@ void DlgUpdate::downloadSuccessful(const QUrl &filepath)
// Try to open the installer. If it opens, quit Cockatrice
if (process.startDetached()) {
QMetaObject::invokeMethod(static_cast<MainWindow *>(parent()), "close", Qt::QueuedConnection);
qCInfo(DlgUpdateLog) << "Opened downloaded update file successfully - closing Cockatrice";
// Close the main window synchronously so settings are saved and file locks are released
// before the NSIS installer (already launched) starts replacing files, then quit the
// application for real in case the close was suppressed (e.g. by a pending prompt).
if (auto *window = qobject_cast<MainWindow *>(parent())) {
window->close();
}
QTimer::singleShot(0, qApp, &QCoreApplication::quit);
close();
} else {
setLabel(tr("Error"));