jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-10 16:24:45 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make SettingsManager params const ref (#5405)

Browse source 
* pass settingsPath by const ref

* pass params by const ref

* cleanup
This commit is contained in:
RickyRister 2025-01-01 21:33:37 -08:00 • committed by GitHub
parent f924b04efd
commit bb4214e28a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 25 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

11
cockatrice/src/settings/settings_manager.cpp
View file

@ -1,11 +1,14 @@
#include "settings_manager.h"
SettingsManager::SettingsManager(QString settingPath, QObject *parent)
SettingsManager::SettingsManager(const QString &settingPath, QObject *parent)
: QObject(parent), settings(settingPath, QSettings::IniFormat)
{
}
void SettingsManager::setValue(QVariant value, QString name, QString group, QString subGroup)
void SettingsManager::setValue(const QVariant &value,
const QString &name,
const QString &group,
const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);
@ -26,7 +29,7 @@ void SettingsManager::setValue(QVariant value, QString name, QString group, QStr
}
}
void SettingsManager::deleteValue(QString name, QString group, QString subGroup)
void SettingsManager::deleteValue(const QString &name, const QString &group, const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);
@ -47,7 +50,7 @@ void SettingsManager::deleteValue(QString name, QString group, QString subGroup)
}
}
QVariant SettingsManager::getValue(QString name, QString group, QString subGroup)
QVariant SettingsManager::getValue(const QString &name, const QString &group, const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);