jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-09-21 09:05:10 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[Completer] Fix popup going offscreen by clamping in screen coordinates

Browse source 
The position clamping in applyPopupWidth() was comparing popup->pos()
(parent coordinates) against screen->availableGeometry() (screen
coordinates).  When the parent widget is not at the screen origin the
clamping computed a position in the wrong coordinate space, placing the
popup offscreen.  Convert to global coordinates first, clamp, then map
back to parent coordinates.
This commit is contained in:
Lukas Brübach 2026-08-17 03:44:44 +02:00
parent 674e32988b
commit bb4c489327
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cockatrice/src/interface/widgets/utility/card_completer_styler.cpp
View file

@ -169,9 +169,12 @@ void CardCompleterStyler::applyPopupWidth()
popup->resize(minWidth, popup->height());
if (!available.isEmpty()) {
QPoint pos = popup->pos();
pos.setX(qBound(available.left(), pos.x(), qMax(available.left(), available.right() - popup->width() + 1)));
popup->move(pos);
// Clamp in screen coordinates, then map back to parent coordinates.
QPoint globalPos = popup->mapToGlobal(QPoint(0, 0));
int clampedGlobalX =
qBound(available.left(), globalPos.x(), qMax(available.left(), available.right() - popup->width() + 1));
QPoint parentPos = popup->mapFromGlobal(QPoint(clampedGlobalX, globalPos.y()));
popup->move(parentPos);
}
}
}